Move the TouchEventQueue to be completely virtual.

Move the TouchEventQueue to be completely virtual.

We need to provide a new implementation of the TouchEventQueue and
the easiest is to rewrite it according to the external interface.
So make the interface completely virtual to support two implementations
for now. Move the old implementation to LegacyTouchEventQueue.

BUG=642368
TBR=creis@chromium.org

Review-Url: https://codereview.chromium.org/2663493003
Cr-Commit-Position: refs/heads/master@{#446701}
Committed: https://chromium.googlesource.com/chromium/src/+/73607ca60d8d03e9ac7397da44a9744d64e444b8

[dtapuska, 2017-01-27 14:44:05]

dtapuska@chromium.org changed reviewers:
+ tdresser@chromium.org

[dtapuska, 2017-01-27 14:44:27]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 14:44:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdresser, 2017-01-27 15:11:57]

https://codereview.chromium.org/2663493003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/legacy_touch_event_queue.cc (right):

https://codereview.chromium.org/2663493003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/legacy_touch_event_queue.cc:284: class
LegacyTouchEventQueue::TouchMoveSlopSuppressor {
We'll need to pull this out to enable code sharing with the
PassThroughTouchEvent queue, right?

It might make sense to do that now (but if you'd prefer to wait, fine by me).

https://codereview.chromium.org/2663493003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/touch_event_queue.cc (right):

https://codereview.chromium.org/2663493003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/touch_event_queue.cc:7: namespace content {
I'd be tempted to get make TouchEventQueue an interface, and get rid of this cc
file.

Is there a good reason to keep this around?

https://codereview.chromium.org/2663493003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/touch_event_queue.h (right):

https://codereview.chromium.org/2663493003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/touch_event_queue.h:21: #include
"ui/gfx/geometry/point_f.h"
We don't need PointF anymore.

https://codereview.chromium.org/2663493003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/touch_event_queue.h:119:
TouchEventQueueClient* client_;
Let's just duplicate this in both subclasses, so we can make this a pure
interface.

[commit-bot: I haz the power, 2017-01-27 15:44:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 15:44:05]

Dry run: This issue passed the CQ dry run.

[dtapuska, 2017-01-27 15:57:39]

PTAL

https://codereview.chromium.org/2663493003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/legacy_touch_event_queue.cc (right):

https://codereview.chromium.org/2663493003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/legacy_touch_event_queue.cc:284: class
LegacyTouchEventQueue::TouchMoveSlopSuppressor {
On 2017/01/27 15:11:56, tdresser wrote:
> We'll need to pull this out to enable code sharing with the
> PassThroughTouchEvent queue, right?
> 
> It might make sense to do that now (but if you'd prefer to wait, fine by me).

Nope I think implementing this on main thread first is easiest.

https://codereview.chromium.org/2663493003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/touch_event_queue.cc (right):

https://codereview.chromium.org/2663493003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/touch_event_queue.cc:7: namespace content {
On 2017/01/27 15:11:56, tdresser wrote:
> I'd be tempted to get make TouchEventQueue an interface, and get rid of this
cc
> file.
> 
> Is there a good reason to keep this around?

Done.

https://codereview.chromium.org/2663493003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/touch_event_queue.h (right):

https://codereview.chromium.org/2663493003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/touch_event_queue.h:119:
TouchEventQueueClient* client_;
On 2017/01/27 15:11:57, tdresser wrote:
> Let's just duplicate this in both subclasses, so we can make this a pure
> interface.

Done.

[tdresser, 2017-01-27 16:07:05]

LGTM, thanks.

[dtapuska, 2017-01-27 16:08:54]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2017-01-27 16:09:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 16:16:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 16:16:50]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dtapuska, 2017-01-27 16:19:33]

dtapuska@chromium.org changed reviewers:
+ creis@chromium.org

[dtapuska, 2017-01-27 16:19:34]

creis@ I'll TBR you. It is silly that we use to be able to modify gyp configs
without an owner review but can't modify the build.gn files.

[dtapuska, 2017-01-27 16:20:12]

Description was changed from

==========
Move the TouchEventQueue to be completely virtual.

We need to provide a new implementation of the TouchEventQueue and
the easiest is to rewrite it according to the external interface.
So make the interface completely virtual to support two implementations
for now. Move the old implementation to LegacyTouchEventQueue.

BUG=642368
==========

to

==========
Move the TouchEventQueue to be completely virtual.

We need to provide a new implementation of the TouchEventQueue and
the easiest is to rewrite it according to the external interface.
So make the interface completely virtual to support two implementations
for now. Move the old implementation to LegacyTouchEventQueue.

BUG=642368
TBR=creis@chromium.org
==========

[dtapuska, 2017-01-27 16:29:44]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2017-01-27 16:30:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 17:20:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485534584233700,
"parent_rev": "4dcd14614295f37dfee188a3d198c02db751d2dc", "commit_rev":
"73607ca60d8d03e9ac7397da44a9744d64e444b8"}

[commit-bot: I haz the power, 2017-01-27 17:22:02]

Description was changed from

==========
Move the TouchEventQueue to be completely virtual.

We need to provide a new implementation of the TouchEventQueue and
the easiest is to rewrite it according to the external interface.
So make the interface completely virtual to support two implementations
for now. Move the old implementation to LegacyTouchEventQueue.

BUG=642368
TBR=creis@chromium.org
==========

to

==========
Move the TouchEventQueue to be completely virtual.

We need to provide a new implementation of the TouchEventQueue and
the easiest is to rewrite it according to the external interface.
So make the interface completely virtual to support two implementations
for now. Move the old implementation to LegacyTouchEventQueue.

BUG=642368
TBR=creis@chromium.org

Review-Url: https://codereview.chromium.org/2663493003
Cr-Commit-Position: refs/heads/master@{#446701}
Committed:
https://chromium.googlesource.com/chromium/src/+/73607ca60d8d03e9ac7397da44a9...
==========

[commit-bot: I haz the power, 2017-01-27 17:22:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/73607ca60d8d03e9ac7397da44a9...

[Charlie Reis, 2017-01-27 21:19:04]

BUILD.gn LGTM