Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2663483002: [cipd] Add AssertOnlyDefaultSubdir. (Closed)

Created:
3 years, 11 months ago by iannucci
Modified:
3 years, 10 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[cipd] Add AssertOnlyDefaultSubdir. This transitional function will end up being called by a bunch of things in subsequent CLs. R=vadimsh@chromium.org BUG=663843 Review-Url: https://codereview.chromium.org/2663483002 Committed: https://github.com/luci/luci-go/commit/88f5293a10b2bcbd534e4e7a28a851b38585f3b1

Patch Set 1 #

Patch Set 2 : Common error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M cipd/client/cipd/common/common.go View 1 2 chunks +16 lines, -0 lines 0 comments Download
M cipd/client/cmd/cipd/main.go View 1 chunk +3 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
iannucci
3 years, 11 months ago (2017-01-27 03:16:04 UTC) #1
Vadim Sh.
lgtm
3 years, 10 months ago (2017-01-27 04:19:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663483002/20001
3 years, 10 months ago (2017-01-27 04:40:53 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 04:53:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/88f5293a10b2bcbd534e4e7a28a851b38585f3b1

Powered by Google App Engine
This is Rietveld 408576698