Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 2663473002: [cipd] Rename new Root terminology to Subdir. (Closed)

Created:
3 years, 10 months ago by iannucci
Modified:
3 years, 10 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[cipd] Rename new Root terminology to Subdir. The new term is confusing with the existing 'root' meaning. Better to nip this one in the bud before it gets messy. R=vadimsh@chromium.org BUG=663843 Review-Url: https://codereview.chromium.org/2663473002 Committed: https://github.com/luci/luci-go/commit/c08a552ab25cc1d8d543dbbe48f83aa0c968205b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -128 lines) Patch
M cipd/client/cipd/common/common.go View 2 chunks +33 lines, -33 lines 0 comments Download
M cipd/client/cipd/common/common_test.go View 6 chunks +24 lines, -24 lines 0 comments Download
M cipd/client/cipd/ensure/bad_test.go View 4 chunks +19 lines, -19 lines 0 comments Download
M cipd/client/cipd/ensure/doc.go View 3 chunks +7 lines, -7 lines 0 comments Download
M cipd/client/cipd/ensure/file.go View 8 chunks +23 lines, -23 lines 0 comments Download
M cipd/client/cipd/ensure/file_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M cipd/client/cipd/ensure/good_test.go View 5 chunks +9 lines, -9 lines 0 comments Download
M cipd/client/cipd/ensure/item_parsers.go View 2 chunks +5 lines, -5 lines 0 comments Download
M cipd/client/cmd/cipd/main.go View 1 chunk +6 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
iannucci
3 years, 10 months ago (2017-01-27 01:38:55 UTC) #1
Vadim Sh.
lgtm
3 years, 10 months ago (2017-01-27 04:17:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663473002/1
3 years, 10 months ago (2017-01-27 04:26:59 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 04:33:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/c08a552ab25cc1d8d543dbbe48f83aa0c968205b

Powered by Google App Engine
This is Rietveld 408576698