[cipd] update internal function signatures in preparation for subdir.

[cipd] update internal function signatures in preparation for subdir.

This doesn't have any real effect: It just prepares all the internal
signatures to make the actual implementation CLs easier.

R=vadimsh@chromium.org
BUG=663843
Review-Url: https://codereview.chromium.org/2654123005
Committed: https://github.com/luci/luci-go/commit/9d4e6852a28839852553860211dca39519771e8c

[iannucci, 2017-01-27 04:27:19]

Description was changed from

==========
[cipd] update internal function signatures in preparation for subdir.

This doesn't have any real effect: It just prepares all the internal
signatures to make the actual implementation CLs easier.

R=vadimsh@chromium.org
BUG=
==========

to

==========
[cipd] update internal function signatures in preparation for subdir.

This doesn't have any real effect: It just prepares all the internal
signatures to make the actual implementation CLs easier.

R=vadimsh@chromium.org
BUG=663843
==========

[Vadim Sh., 2017-01-27 04:31:01]

lgtm

https://codereview.chromium.org/2654123005/diff/20001/cipd/client/cipd/client.go
File cipd/client/cipd/client.go (right):

https://codereview.chromium.org/2654123005/diff/20001/cipd/client/cipd/client...
cipd/client/cipd/client.go:1377: panic(err)
:'(
though it should not happen now, so whatever

[iannucci, 2017-01-27 04:39:45]

On 2017/01/27 04:31:01, Vadim Sh. wrote:
> lgtm
> 
>
https://codereview.chromium.org/2654123005/diff/20001/cipd/client/cipd/client.go
> File cipd/client/cipd/client.go (right):
> 
>
https://codereview.chromium.org/2654123005/diff/20001/cipd/client/cipd/client...
> cipd/client/cipd/client.go:1377: panic(err)
> :'(
> though it should not happen now, so whatever

It will go away in future CL too when this becomes implemented for real.

[Vadim Sh., 2017-01-27 05:00:34]

On 2017/01/27 04:39:45, iannucci wrote:
> On 2017/01/27 04:31:01, Vadim Sh. wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/2654123005/diff/20001/cipd/client/cipd/client.go
> > File cipd/client/cipd/client.go (right):
> > 
> >
>
https://codereview.chromium.org/2654123005/diff/20001/cipd/client/cipd/client...
> > cipd/client/cipd/client.go:1377: panic(err)
> > :'(
> > though it should not happen now, so whatever
> 
> It will go away in future CL too when this becomes implemented for real.

Yeah.

I meant I'm not a fan of panics in general. Every error should have a clear
cause that triggers it. It's alright here. The panic means it is just not
implemented yet...

[iannucci, 2017-01-27 05:31:26]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2017-01-27 05:31:27]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2654123005/#ps40001
(title: "root->subdir")

[commit-bot: I haz the power, 2017-01-27 05:31:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 05:38:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485495086722050,
"parent_rev": "88f5293a10b2bcbd534e4e7a28a851b38585f3b1", "commit_rev":
"9d4e6852a28839852553860211dca39519771e8c"}

[commit-bot: I haz the power, 2017-01-27 05:38:35]

Description was changed from

==========
[cipd] update internal function signatures in preparation for subdir.

This doesn't have any real effect: It just prepares all the internal
signatures to make the actual implementation CLs easier.

R=vadimsh@chromium.org
BUG=663843
==========

to

==========
[cipd] update internal function signatures in preparation for subdir.

This doesn't have any real effect: It just prepares all the internal
signatures to make the actual implementation CLs easier.

R=vadimsh@chromium.org
BUG=663843

Review-Url: https://codereview.chromium.org/2654123005
Committed:
https://github.com/luci/luci-go/commit/9d4e6852a28839852553860211dca39519771e8c
==========

[commit-bot: I haz the power, 2017-01-27 05:38:36]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/9d4e6852a28839852553860211dca39519771e8c