Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2663383003: Revert of mash: Fix MusPropertyMirrorAsh for owned properties; add test. (Closed)

Created:
3 years, 10 months ago by msw
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mash: Fix MusPropertyMirrorAsh for owned properties; add test. (patchset #4 id:100001 of https://codereview.chromium.org/2669633003/ ) Reason for revert: Likely cause failing tests, see: http://crbug.com/687472 Original issue's description: > mash: Fix MusPropertyMirrorAsh for owned properties; add test. > > I fixed gfx::ImageSkia in: https://codereview.chromium.org/2667743003 > This CL fixes the owned string properties similarly. > Move the ash mirror to it's own file; add mash_unittest fixtures. > > Fallout from move to ash/public/cpp: > -Move shelf_item_types.* to ash/public/cpp > (TODO: remove stub header used for temporary forwarding) > -Move kInvalidShelfID to avoid moving shelf_constants.h (better home) > -Move two mirrored ash window properties to ash/public/cpp > > BUG=686936 > TEST=automated; no crashes running apps on chrome --mash. > R=sky@chromium.org > > Review-Url: https://codereview.chromium.org/2669633003 > Cr-Commit-Position: refs/heads/master@{#447455} > Committed: https://chromium.googlesource.com/chromium/src/+/612e45de4250e73fa0df767121d7d6ae4f2c9c83 TBR=sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=686936 Review-Url: https://codereview.chromium.org/2663383003 Cr-Commit-Position: refs/heads/master@{#447474} Committed: https://chromium.googlesource.com/chromium/src/+/dd5389da916714d4430b6b2a94f69a733aac5075

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -351 lines) Patch
M ash/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ash/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D ash/common/mus_property_mirror_ash_unittest.cc View 1 chunk +0 lines, -90 lines 0 comments Download
M ash/common/shelf/shelf_constants.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/common/shelf/shelf_item_types.h View 1 chunk +83 lines, -3 lines 0 comments Download
A ash/common/shelf/shelf_item_types.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M ash/common/wm_window.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/mus/window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/public/cpp/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
D ash/public/cpp/mus_property_mirror_ash.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ash/public/cpp/mus_property_mirror_ash.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D ash/public/cpp/shelf_item_types.h View 1 chunk +0 lines, -90 lines 0 comments Download
D ash/public/cpp/shelf_item_types.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D ash/public/cpp/window_properties.h View 1 chunk +0 lines, -34 lines 0 comments Download
D ash/public/cpp/window_properties.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M ash/shell/panel_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_properties.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ash/wm/window_properties.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/settings_window_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc View 3 chunks +56 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
msw
Created Revert of mash: Fix MusPropertyMirrorAsh for owned properties; add test.
3 years, 10 months ago (2017-02-01 08:32:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663383003/1
3 years, 10 months ago (2017-02-01 08:32:41 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 08:34:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dd5389da916714d4430b6b2a94f6...

Powered by Google App Engine
This is Rietveld 408576698