Chromium Code Reviews
DescriptionRevert of mash: Fix MusPropertyMirrorAsh for owned properties; add test. (patchset #4 id:100001 of https://codereview.chromium.org/2669633003/ )
Reason for revert:
Likely cause failing tests, see: http://crbug.com/687472
Original issue's description:
> mash: Fix MusPropertyMirrorAsh for owned properties; add test.
>
> I fixed gfx::ImageSkia in: https://codereview.chromium.org/2667743003
> This CL fixes the owned string properties similarly.
> Move the ash mirror to it's own file; add mash_unittest fixtures.
>
> Fallout from move to ash/public/cpp:
> -Move shelf_item_types.* to ash/public/cpp
> (TODO: remove stub header used for temporary forwarding)
> -Move kInvalidShelfID to avoid moving shelf_constants.h (better home)
> -Move two mirrored ash window properties to ash/public/cpp
>
> BUG=686936
> TEST=automated; no crashes running apps on chrome --mash.
> R=sky@chromium.org
>
> Review-Url: https://codereview.chromium.org/2669633003
> Cr-Commit-Position: refs/heads/master@{#447455}
> Committed: https://chromium.googlesource.com/chromium/src/+/612e45de4250e73fa0df767121d7d6ae4f2c9c83
TBR=sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=686936
Review-Url: https://codereview.chromium.org/2663383003
Cr-Commit-Position: refs/heads/master@{#447474}
Committed: https://chromium.googlesource.com/chromium/src/+/dd5389da916714d4430b6b2a94f69a733aac5075
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|