s390: TF Optimize 32-bit Mul/Div/Mod/Popcnt

s390: TF Optimize 32-bit Mul/Div/Mod/Popcnt

R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com
BUG=

Review-Url: https://codereview.chromium.org/2662963002
Cr-Commit-Position: refs/heads/master@{#42791}
Committed: https://chromium.googlesource.com/v8/v8/+/0d9b0dcf4349950ab7a3a406b34739fc4a316fb2

[john.yan, 2017-01-30 20:02:33]

ptal

[JaideepBajwa, 2017-01-30 20:09:56]

lgtm, with nits.

https://codereview.chromium.org/2662963002/diff/1/src/s390/simulator-s390.cc
File src/s390/simulator-s390.cc (right):

https://codereview.chromium.org/2662963002/diff/1/src/s390/simulator-s390.cc#...
src/s390/simulator-s390.cc:10370: DCHECK_OPCODE(LGBR);
should this be DCHECK_OPCODE(LLGCR)?

https://codereview.chromium.org/2662963002/diff/1/src/s390/simulator-s390.cc#...
src/s390/simulator-s390.cc:10454: DCHECK_OPCODE(LBR);
should this be DCHECK_OPCODE(LLCR)?

[john.yan, 2017-01-30 20:13:57]

The CQ bit was checked by jyan@ca.ibm.com

[john.yan, 2017-01-30 20:13:57]

The patchset sent to the CQ was uploaded after l-g-t-m from bjaideep@ca.ibm.com
Link to the patchset: https://codereview.chromium.org/2662963002/#ps20001
(title: "fix dcheck")

[commit-bot: I haz the power, 2017-01-30 20:13:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 20:14:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 20:14:01]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[john.yan, 2017-01-30 20:18:38]

On 2017/01/30 20:14:01, commit-bot: I haz the power wrote:
> No L-G-T-M from a valid reviewer yet. 
> CQ run can only be started by full committers or once the patch has
> received an L-G-T-M from a full committer.
> Even if an L-G-T-M may have been provided, it was from a non-committer,
> _not_ a full super star committer.
> Committers are members of the group "project-v8-committers".
> Note that this has nothing to do with OWNERS files.

lgtm

[john.yan, 2017-01-30 20:18:52]

The CQ bit was checked by jyan@ca.ibm.com

[commit-bot: I haz the power, 2017-01-30 20:19:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 20:19:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 20:19:03]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[john.yan, 2017-01-30 20:20:28]

Description was changed from

==========
s390: TF Optimize 32-bit Mul/Div/Mod/Popcnt

R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com
BUG=
==========

to

==========
s390: TF Optimize 32-bit Mul/Div/Mod/Popcnt

R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com
BUG=
==========

[john.yan, 2017-01-30 20:20:28]

jyan@ca.ibm.com changed reviewers:
+ machenbach@chromium.org

[john.yan, 2017-01-30 20:22:15]

On 2017/01/30 20:19:03, commit-bot: I haz the power wrote:
> No L-G-T-M from a valid reviewer yet. 
> CQ run can only be started by full committers or once the patch has
> received an L-G-T-M from a full committer.
> Even if an L-G-T-M may have been provided, it was from a non-committer,
> _not_ a full super star committer.
> Committers are members of the group "project-v8-committers".
> Note that this has nothing to do with OWNERS files.

Hello Michael @machenbach@chromium.org, seems like lgtm doesn't work for
JaideepBajwa. Could you please take a look?

[JoranSiu, 2017-01-30 20:31:54]

lgtm

[JaideepBajwa, 2017-01-30 20:34:13]

On 2017/01/30 20:22:15, john.yan wrote:
> On 2017/01/30 20:19:03, commit-bot: I haz the power wrote:
> > No L-G-T-M from a valid reviewer yet. 
> > CQ run can only be started by full committers or once the patch has
> > received an L-G-T-M from a full committer.
> > Even if an L-G-T-M may have been provided, it was from a non-committer,
> > _not_ a full super star committer.
> > Committers are members of the group "project-v8-committers".
> > Note that this has nothing to do with OWNERS files.
> 
> Hello Michael mailto:@machenbach@chromium.org, seems like lgtm doesn't work
for
> JaideepBajwa. Could you please take a look?

not sure why this happens sometimes, I am listed in the OWNERS file for s390/PPC
files.
Is there anything else that I'm missing?

[john.yan, 2017-01-30 20:47:52]

The CQ bit was checked by jyan@ca.ibm.com

[commit-bot: I haz the power, 2017-01-30 20:48:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 21:13:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485809272435550,
"parent_rev": "d293656481cfefd69dd26301c20e480bb4878b54", "commit_rev":
"0d9b0dcf4349950ab7a3a406b34739fc4a316fb2"}

[commit-bot: I haz the power, 2017-01-30 21:13:28]

Description was changed from

==========
s390: TF Optimize 32-bit Mul/Div/Mod/Popcnt

R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com
BUG=
==========

to

==========
s390: TF Optimize 32-bit Mul/Div/Mod/Popcnt

R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com
BUG=

Review-Url: https://codereview.chromium.org/2662963002
Cr-Commit-Position: refs/heads/master@{#42791}
Committed:
https://chromium.googlesource.com/v8/v8/+/0d9b0dcf4349950ab7a3a406b34739fc4a3...
==========

[commit-bot: I haz the power, 2017-01-30 21:13:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/0d9b0dcf4349950ab7a3a406b34739fc4a3...