Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2662783005: Revert of Make some small style cleanups in tracing_metric.html (Closed)

Created:
3 years, 10 months ago by nednguyen
Modified:
3 years, 10 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org, Zhen Wang
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Make some small style cleanups in tracing_metric.html (patchset #1 id:1 of https://codereview.chromium.org/2654433016/ ) Reason for revert: This is causing tracing d8 tests failing on Windows, blocking Catapult CQ (https://codereview.chromium.org/2660913002/). Probably win's d8 version need to be updated. Original issue's description: > Make some small style cleanups in tracing_metric.html > > There are a few small ways that the current tracing style diverges from > the tracing_metric style, so this changes tracing_metric to use the > newer tracing styles. > > NOTRY=true > > Review-Url: https://codereview.chromium.org/2654433016 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c3f25757340bf0a82c398d19b5e5591cfc25404e TBR=benjhayden@chromium.org,charliea@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2662783005 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/1875364a1c5660b00b267b58ea99b663e6eadf54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M tracing/tracing/metrics/tracing_metric.html View 4 chunks +18 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
nednguyen
Created Revert of Make some small style cleanups in tracing_metric.html
3 years, 10 months ago (2017-01-30 16:02:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662783005/1
3 years, 10 months ago (2017-01-30 16:02:53 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 16:23:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698