|
|
Created:
3 years, 10 months ago by charliea (OOO until 10-5) Modified:
3 years, 10 months ago Reviewers:
benjhayden CC:
catapult-reviews_chromium.org, tracing-review_chromium.org, Zhen Wang Target Ref:
refs/heads/master Project:
catapult Visibility:
Public. |
DescriptionMake some small style cleanups in tracing_metric.html
There are a few small ways that the current tracing style diverges from
the tracing_metric style, so this changes tracing_metric to use the
newer tracing styles.
NOTRY=true
Review-Url: https://codereview.chromium.org/2654433016
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c3f25757340bf0a82c398d19b5e5591cfc25404e
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
charliea@chromium.org changed reviewers: + benjhayden@chromium.org
Description was changed from ========== Make some small style cleanups in tracing_metric.html ========== to ========== Make some small style cleanups in tracing_metric.html There are a few small ways that the current tracing style diverges from the tracing_metric style, so this changes tracing_metric to use the newer tracing styles. ==========
lgtm
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Make some small style cleanups in tracing_metric.html There are a few small ways that the current tracing style diverges from the tracing_metric style, so this changes tracing_metric to use the newer tracing styles. ========== to ========== Make some small style cleanups in tracing_metric.html There are a few small ways that the current tracing style diverges from the tracing_metric style, so this changes tracing_metric to use the newer tracing styles. NOTRY=true ==========
Submitting with NOTRY=true because the failures don't look related to this CL.
The CQ bit was unchecked by charliea@chromium.org
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1485566111257440, "parent_rev": "50a04d086288430beb3a1d047bf75388e041710e", "commit_rev": "c3f25757340bf0a82c398d19b5e5591cfc25404e"}
Message was sent while issue was closed.
Description was changed from ========== Make some small style cleanups in tracing_metric.html There are a few small ways that the current tracing style diverges from the tracing_metric style, so this changes tracing_metric to use the newer tracing styles. NOTRY=true ========== to ========== Make some small style cleanups in tracing_metric.html There are a few small ways that the current tracing style diverges from the tracing_metric style, so this changes tracing_metric to use the newer tracing styles. NOTRY=true Review-Url: https://codereview.chromium.org/2654433016 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2662783005/ by nednguyen@google.com. The reason for reverting is: This is causing tracing d8 tests failing on Windows, blocking Catapult CQ (https://codereview.chromium.org/2660913002/). Probably win's d8 version need to be updated. .
Message was sent while issue was closed.
On 2017/01/28 01:15:04, charliea wrote: > Submitting with NOTRY=true because the failures don't look related to this CL. Hmhh, I am not sure about this. |