Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2654433016: Make some small style cleanups in tracing_metric.html (Closed)

Created:
3 years, 10 months ago by charliea (OOO until 10-5)
Modified:
3 years, 10 months ago
Reviewers:
benjhayden
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org, Zhen Wang
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Make some small style cleanups in tracing_metric.html There are a few small ways that the current tracing style diverges from the tracing_metric style, so this changes tracing_metric to use the newer tracing styles. NOTRY=true Review-Url: https://codereview.chromium.org/2654433016 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c3f25757340bf0a82c398d19b5e5591cfc25404e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M tracing/tracing/metrics/tracing_metric.html View 4 chunks +14 lines, -17 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
charliea (OOO until 10-5)
3 years, 10 months ago (2017-01-28 00:01:33 UTC) #2
benjhayden
lgtm
3 years, 10 months ago (2017-01-28 00:03:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654433016/1
3 years, 10 months ago (2017-01-28 00:04:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Windows%20Tryserver/builds/6124)
3 years, 10 months ago (2017-01-28 00:43:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654433016/1
3 years, 10 months ago (2017-01-28 00:49:58 UTC) #10
charliea (OOO until 10-5)
Submitting with NOTRY=true because the failures don't look related to this CL.
3 years, 10 months ago (2017-01-28 01:15:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654433016/1
3 years, 10 months ago (2017-01-28 01:15:17 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c3f25757340bf0a82c398d19b5e5591cfc25404e
3 years, 10 months ago (2017-01-28 01:16:50 UTC) #18
nednguyen
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2662783005/ by nednguyen@google.com. ...
3 years, 10 months ago (2017-01-30 16:02:47 UTC) #19
nednguyen
3 years, 10 months ago (2017-01-30 16:07:29 UTC) #20
Message was sent while issue was closed.
On 2017/01/28 01:15:04, charliea wrote:
> Submitting with NOTRY=true because the failures don't look related to this CL.

Hmhh, I am not sure about this.

Powered by Google App Engine
This is Rietveld 408576698