Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: tracing/tracing/metrics/tracing_metric.html

Issue 2662783005: Revert of Make some small style cleanups in tracing_metric.html (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/tracing_metric.html
diff --git a/tracing/tracing/metrics/tracing_metric.html b/tracing/tracing/metrics/tracing_metric.html
index 2ed6661217f986684a55fbc336cd03ecd8c5f349..fa81c2f789f723de8626ef4a84a98e93813f8e25 100644
--- a/tracing/tracing/metrics/tracing_metric.html
+++ b/tracing/tracing/metrics/tracing_metric.html
@@ -36,16 +36,17 @@
function addMemoryInfraHistograms(
histograms, model, categoryNamesToTotalEventSizes) {
var memoryDumpCount = model.globalMemoryDumps.length;
- if (memoryDumpCount === 0) return;
+ if (memoryDumpCount === 0)
+ return;
var totalOverhead = 0;
var nonMemoryInfraThreadOverhead = 0;
var overheadByProvider = {};
- for (var process of Object.values(model.processes)) {
- for (var thread of Object.values(process.threads)) {
- for (var slice of Object.values(thread.sliceGroup.slices)) {
- if (slice.category !== MEMORY_INFRA_TRACING_CATEGORY) return;
-
+ tr.b.iterItems(model.processes, function(pid, process) {
+ tr.b.iterItems(process.threads, function(tid, thread) {
+ tr.b.iterItems(thread.sliceGroup.slices, (unusedSliceId, slice) => {
+ if (slice.category !== MEMORY_INFRA_TRACING_CATEGORY)
+ return;
totalOverhead += slice.duration;
if (thread.name !== 'MemoryInfra')
nonMemoryInfraThreadOverhead += slice.duration;
@@ -59,9 +60,9 @@
durationAndCount.duration += slice.duration;
durationAndCount.count++;
}
- }
- }
- }
+ });
+ });
+ });
addTimeDurationHistogram(
'Average CPU overhead on all threads per memory-infra dump',
@@ -70,11 +71,11 @@
'Average CPU overhead on non-memory-infra threads per memory-infra ' +
'dump',
nonMemoryInfraThreadOverhead / memoryDumpCount, histograms);
- for (var [providerName, overhead] of Object.entries(overheadByProvider)) {
+ tr.b.iterItems(overheadByProvider, function(providerName, overhead) {
addTimeDurationHistogram(
'Average CPU overhead of ' + providerName + ' per OnMemoryDump call',
overhead.duration / overhead.count, histograms);
- }
+ });
var memoryInfraEventsSize =
categoryNamesToTotalEventSizes.get(MEMORY_INFRA_TRACING_CATEGORY);
@@ -98,10 +99,12 @@
}
var eventStats = model.stats.allTraceEventStatsInTimeIntervals;
- eventStats.sort((a, b) => a.timeInterval - b.timeInterval);
-
- var totalTraceBytes = eventStats.reduce(
- (a, b) => (a + b.totalEventSizeinBytes), 0);
+ eventStats.sort(function(a, b) {
+ return a.timeInterval - b.timeInterval;
+ });
+
+ var totalTraceBytes = eventStats.reduce((a, b) =>
+ (a + b.totalEventSizeinBytes), 0);
// We maintain a sliding window of records [start ... end-1] where end
// increments each time through the loop, and we move start just far enough
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698