Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 2662633002: Paring down the table to only include important values. (Closed)

Created:
3 years, 10 months ago by jessimb
Modified:
3 years, 10 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Paring down the table to only include important values. After talking with @perezju, we learned that the only important value from the table is average. This CL removes the complexity around looking for the rest of the unneeded and (potentially incorrect - https://codereview.chromium.org/2649043007) statistics. Demo: https://dev-jessimb-837c81ea-dot-chromeperf.appspot.com/speed_releasing/MemoryTest5?revA=1479546161&revB=1485025126 http://i.imgur.com/nyh3iSA.png BUG=catapult:#3141

Patch Set 1 #

Patch Set 2 : Editing wording on /create_health_report #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -231 lines) Patch
M dashboard/dashboard/create_health_report_test.py View 9 chunks +33 lines, -9 lines 0 comments Download
M dashboard/dashboard/elements/create-health-report-page.html View 1 1 chunk +2 lines, -4 lines 0 comments Download
M dashboard/dashboard/elements/speed-releasing-table.html View 4 chunks +15 lines, -44 lines 0 comments Download
M dashboard/dashboard/elements/speed-releasing-table-test.html View 2 chunks +7 lines, -77 lines 0 comments Download
M dashboard/dashboard/models/table_config.py View 2 chunks +7 lines, -4 lines 0 comments Download
M dashboard/dashboard/speed_releasing.py View 3 chunks +4 lines, -28 lines 0 comments Download
M dashboard/dashboard/speed_releasing_test.py View 4 chunks +18 lines, -65 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (3 generated)
eakuefner
3 years, 10 months ago (2017-01-27 22:14:34 UTC) #4
So, as I mentioned in my comments on the big CL, I think you should probably
invert these. Merge this simplification with the original CL, and make this CL
about extending it with more columns.

Of course, the modification to this CL I'm proposing will be incorrect, but it
would be a good WIP starting point while we wait for histograms to be uploaded
to the dashboard.

Powered by Google App Engine
This is Rietveld 408576698