Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Unified Diff: dashboard/dashboard/elements/speed-releasing-table.html

Issue 2662633002: Paring down the table to only include important values. (Closed)
Patch Set: Editing wording on /create_health_report Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/elements/speed-releasing-table.html
diff --git a/dashboard/dashboard/elements/speed-releasing-table.html b/dashboard/dashboard/elements/speed-releasing-table.html
index f08eeb9bb83046632df31f9bce72ef03eb398d33..d5298941262a60420bb8fd5043e0dd2a2a989f84 100644
--- a/dashboard/dashboard/elements/speed-releasing-table.html
+++ b/dashboard/dashboard/elements/speed-releasing-table.html
@@ -66,21 +66,14 @@ found in the LICENSE file.
<th colspan="2" rowspan="2"></th>
<template is="dom-repeat" items="{{tableConfig.revisions}}"
as="rev">
- <th colspan="4">Version: {{rev}}</th>
+ <th>Version: {{rev}}</th>
</template>
<th colspan="4">Change</th>
</tr>
<tr>
- <th><i>n</i></th>
<th>Average</th>
- <th>Peak</th>
- <th>StdDev</th>
- <th><i>n</i></th>
<th>Average</th>
- <th>Peak</th>
- <th>StdDev</th>
<th colspan="2">Average</th>
- <th colspan="2">Peak</th>
</tr>
</thead>
<template is="dom-repeat" items="{{tableConfig.tests}}"
@@ -95,15 +88,10 @@ found in the LICENSE file.
<th>{{getPrettyTestName(test)}}</th>
<template is="dom-repeat" items="{{tableConfig.revisions}}"
as="rev">
- <template is="dom-repeat" items="{{stats}}" as="stat">
- <td>{{getValue(rev, bot, test, stat)}}</td>
- </template>
- </template>
- <template is="dom-repeat" items="{{changeStats}}"
- as="change">
- <td>{{getDifference(bot, test, change, 'false')}}</td>
- <td>{{getDifference(bot, test, change, 'true')}}</td>
+ <td>{{getValue(rev, bot, test)}}</td>
</template>
+ <td>{{getDifference(bot, test, 'false')}}</td>
+ <td>{{getDifference(bot, test, 'true')}}</td>
</tr>
</template>
</table> <br>
@@ -142,29 +130,15 @@ found in the LICENSE file.
type: String,
value: ''
},
- stats: {
- type: Array,
- value: ['count', 'avg', 'max', 'std']
- },
- changeStats: {
- type: Array,
- value: ['avg', 'max']
- },
- categoryCount: {
- type: Number,
- value: 0
- }
},
/**
- * Gets the specified value given a rev, bot, test, and one of
+ * Gets the specified value given a rev, bot, test, and one of
* this.stats (count, avg, max, std).
*/
- getValue: function(rev, bot, test, kind) {
- var kind = '_' + kind;
- var newTest = test.replace(/_[*]/g, kind);
- var value = this.tableConfig.values[rev][bot][newTest];
- var unit = this.tableConfig.units[newTest];
+ getValue: function(rev, bot, test) {
+ var value = this.tableConfig.values[rev][bot][test];
+ var unit = this.tableConfig.units[test];
if (tr.b.Unit.byName[unit]) {
return (tr.b.Unit.byName[unit].format(value));
} else {
@@ -173,27 +147,24 @@ found in the LICENSE file.
},
/**
- * Computes the abs/relative difference for the specified test kind
- * (peak, avg).
+ * Computes the abs/relative difference for the specified test.
*/
- getDifference: function(bot, test, kind, abs) {
- var kind = '_' + kind;
- var newTest = test.replace(/_[*]/g, kind);
+ getDifference: function(bot, test, abs) {
if (this.tableConfig.revisions.length == 2) {
var revA = this.tableConfig.revisions[0];
var revB = this.tableConfig.revisions[1];
if (abs == 'true') {
- var difference = this.tableConfig.values[revB][bot][newTest] -
- this.tableConfig.values[revA][bot][newTest];
- var unit = this.tableConfig.units[newTest];
+ var difference = this.tableConfig.values[revB][bot][test] -
+ this.tableConfig.values[revA][bot][test];
+ var unit = this.tableConfig.units[test];
if (tr.b.Unit.byName[unit]) {
return (tr.b.Unit.byName[unit].format(difference));
} else {
return difference;
}
} else {
- var relDiff = (this.tableConfig.values[revB][bot][newTest] /
- this.tableConfig.values[revA][bot][newTest]) - 1;
+ var relDiff = (this.tableConfig.values[revB][bot][test] /
+ this.tableConfig.values[revA][bot][test]) - 1;
return (tr.b.Unit.byName['normalizedPercentage']
.format(relDiff));
}

Powered by Google App Engine
This is Rietveld 408576698