Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1812)

Unified Diff: dashboard/dashboard/models/table_config.py

Issue 2662633002: Paring down the table to only include important values. (Closed)
Patch Set: Editing wording on /create_health_report Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/models/table_config.py
diff --git a/dashboard/dashboard/models/table_config.py b/dashboard/dashboard/models/table_config.py
index 77e69ac8578554e47447cd79e2f7aa07597c6585..edd6e6e247235ec59b37797303605544d576b451 100644
--- a/dashboard/dashboard/models/table_config.py
+++ b/dashboard/dashboard/models/table_config.py
@@ -31,6 +31,7 @@ import json
from google.appengine.ext import ndb
+from dashboard.common import utils
from dashboard.models import internal_only_model
@@ -96,10 +97,12 @@ def CreateTableConfig(name, bots, tests, layout, username):
error_message = '%s already exists.' % name
return None, error_message
- for test in tests:
- if '_*' not in test:
- error_message = '%s does not contain _*.' % test
- return None, error_message
+ for bot in bots:
+ for test in tests:
+ test_key = utils.TestMetadataKey(bot + '/' + test)
+ if not test_key.get():
+ error_message = '%s is not a valid test.' % test
+ return None, error_message
# Input validates, create table now.
error_message = 'TableConfig created successfully.'
« no previous file with comments | « dashboard/dashboard/elements/speed-releasing-table-test.html ('k') | dashboard/dashboard/speed_releasing.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698