Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2662503002: Convert StartPageService and ZoomController to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
xiyuan, Dan Beam
CC:
chromium-reviews, tfarina, Matt Giuca
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert StartPageService and ZoomController to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2662503002 Cr-Commit-Position: refs/heads/master@{#446819} Committed: https://chromium.googlesource.com/chromium/src/+/e1f39841ab7e989b300f08d90f480b247a08ccf6

Patch Set 1 #

Patch Set 2 : fix unittest #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -41 lines) Patch
M chrome/browser/ui/app_list/start_page_service.h View 2 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/ui/app_list/start_page_service.cc View 3 chunks +18 lines, -18 lines 4 comments Download
M chrome/browser/ui/zoom/zoom_controller_unittest.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M components/zoom/zoom_controller.h View 1 chunk +2 lines, -3 lines 0 comments Download
M components/zoom/zoom_controller.cc View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
jam
dbeam: components xiyuan: the rest I had to do these together because of the comment ...
3 years, 10 months ago (2017-01-27 06:24:36 UTC) #11
xiyuan
lgtm
3 years, 10 months ago (2017-01-27 15:31:50 UTC) #12
Dan Beam
https://codereview.chromium.org/2662503002/diff/20001/chrome/browser/ui/app_list/start_page_service.cc File chrome/browser/ui/app_list/start_page_service.cc (left): https://codereview.chromium.org/2662503002/diff/20001/chrome/browser/ui/app_list/start_page_service.cc#oldcode576 chrome/browser/ui/app_list/start_page_service.cc:576: void StartPageService::DidFailProvisionalLoad( did this only apply to the main ...
3 years, 10 months ago (2017-01-27 20:33:21 UTC) #13
jam
https://codereview.chromium.org/2662503002/diff/20001/chrome/browser/ui/app_list/start_page_service.cc File chrome/browser/ui/app_list/start_page_service.cc (left): https://codereview.chromium.org/2662503002/diff/20001/chrome/browser/ui/app_list/start_page_service.cc#oldcode576 chrome/browser/ui/app_list/start_page_service.cc:576: void StartPageService::DidFailProvisionalLoad( On 2017/01/27 20:33:21, Dan Beam wrote: > ...
3 years, 10 months ago (2017-01-27 21:28:57 UTC) #14
Dan Beam
lgtm then, just wanted to make sure these are equivalent as possible to the previous ...
3 years, 10 months ago (2017-01-27 21:55:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662503002/20001
3 years, 10 months ago (2017-01-27 23:05:56 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 23:14:55 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e1f39841ab7e989b300f08d90f48...

Powered by Google App Engine
This is Rietveld 408576698