Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: chrome/browser/ui/app_list/start_page_service.h

Issue 2662503002: Convert StartPageService and ZoomController to use the new navigation callbacks. (Closed)
Patch Set: fix unittest Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/start_page_service.h
diff --git a/chrome/browser/ui/app_list/start_page_service.h b/chrome/browser/ui/app_list/start_page_service.h
index 30200759093ab37c92442e82f3a100d1cb41eba1..51819825a0da5c4252534d044156d2ccd764259b 100644
--- a/chrome/browser/ui/app_list/start_page_service.h
+++ b/chrome/browser/ui/app_list/start_page_service.h
@@ -28,8 +28,6 @@
#include "ui/app_list/speech_ui_model_observer.h"
namespace content {
-struct FrameNavigateParams;
-struct LoadCommittedDetails;
struct SpeechRecognitionSessionPreamble;
}
@@ -144,14 +142,8 @@ class StartPageService : public KeyedService,
void Shutdown() override;
// contents::WebContentsObserver overrides;
- void DidNavigateMainFrame(
- const content::LoadCommittedDetails& details,
- const content::FrameNavigateParams& params) override;
- void DidFailProvisionalLoad(content::RenderFrameHost* render_frame_host,
- const GURL& validated_url,
- int error_code,
- const base::string16& error_description,
- bool was_ignored_by_handler) override;
+ void DidFinishNavigation(
+ content::NavigationHandle* navigation_handle) override;
// Change the known microphone availability. |available| should be true if
// the microphone exists and is available for use.
« no previous file with comments | « no previous file | chrome/browser/ui/app_list/start_page_service.cc » ('j') | chrome/browser/ui/app_list/start_page_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698