Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1982)

Unified Diff: chrome/browser/ui/zoom/zoom_controller_unittest.cc

Issue 2662503002: Convert StartPageService and ZoomController to use the new navigation callbacks. (Closed)
Patch Set: fix unittest Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/zoom/zoom_controller_unittest.cc
diff --git a/chrome/browser/ui/zoom/zoom_controller_unittest.cc b/chrome/browser/ui/zoom/zoom_controller_unittest.cc
index 18f76df90678a25aabd48d921efe3c8b90e09b41..835867d5817b4e09ed56a54c97a960a27c790fd1 100644
--- a/chrome/browser/ui/zoom/zoom_controller_unittest.cc
+++ b/chrome/browser/ui/zoom/zoom_controller_unittest.cc
@@ -12,8 +12,7 @@
#include "components/zoom/zoom_controller.h"
#include "components/zoom/zoom_observer.h"
#include "content/public/browser/host_zoom_map.h"
-#include "content/public/browser/navigation_details.h"
-#include "content/public/common/frame_navigate_params.h"
+#include "content/public/browser/navigation_handle.h"
#include "content/public/test/test_renderer_host.h"
#include "content/public/test/test_utils.h"
#include "ipc/ipc_message.h"
@@ -54,8 +53,10 @@ TEST_F(ZoomControllerTest, DidNavigateMainFrame) {
false);
ZoomChangedWatcher zoom_change_watcher(zoom_controller_.get(),
zoom_change_data);
- zoom_controller_->DidNavigateMainFrame(content::LoadCommittedDetails(),
- content::FrameNavigateParams());
+ std::unique_ptr<content::NavigationHandle> navigation_handle =
+ content::NavigationHandle::CreateNavigationHandleForTesting(
+ GURL(), rvh()->GetMainFrame(), true);
+ zoom_controller_->DidFinishNavigation(navigation_handle.get());
zoom_change_watcher.Wait();
}

Powered by Google App Engine
This is Rietveld 408576698