Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm

Issue 2662473003: Removing "All Bookmarks" (Closed)
Patch Set: feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm b/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
index f39f7ad58551811b24ea6c7319b852fee6f353a9..64d09643ba93396edeed8f597c8126a4f6da5ef0 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
@@ -1005,11 +1005,7 @@ id<GREYMatcher> ActionSheet(Action action) {
[[self class] removeBookmarkWithTitle:@"Folder 1"];
NSString* rootFolderTitle = nil;
- if (experimental_flags::IsAllBookmarksEnabled()) {
- rootFolderTitle = @"Bookmarks";
- } else {
- rootFolderTitle = @"Mobile Bookmarks";
- }
+ rootFolderTitle = @"Mobile Bookmarks";
// Folder 2 and 3 are now deleted, UI should have moved to top level folder.
[[EarlGrey
@@ -1028,10 +1024,6 @@ id<GREYMatcher> ActionSheet(Action action) {
// Test that the root folder is selected in the menu. This is only the case
// on iPhone.
- if (experimental_flags::IsAllBookmarksEnabled()) {
- rootFolderTitle = @"All Bookmarks";
- }
-
GREYElementMatcherBlock* selectedMatcher =
[GREYElementMatcherBlock matcherWithMatchesBlock:^BOOL(id element) {
UITableViewCell* cell = (UITableViewCell*)element;
@@ -1301,11 +1293,7 @@ id<GREYMatcher> ActionSheet(Action action) {
// Navigates to the bookmark manager UI, and selects the top level folder.
+ (void)openTopLevelBookmarksFolder {
- if (experimental_flags::IsAllBookmarksEnabled()) {
- [BookmarksTestCase openBookmarkFolder:@"All Bookmarks"];
- } else {
- [BookmarksTestCase openMobileBookmarks];
- }
+ [BookmarksTestCase openMobileBookmarks];
}
// Navigates to the bookmark manager UI, and selects MobileBookmarks.

Powered by Google App Engine
This is Rietveld 408576698