Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.mm

Issue 2662473003: Removing "All Bookmarks" (Closed)
Patch Set: feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.mm b/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.mm
index 4c6a27bc5f9edfed447bb5df9ab716ab1a00071c..80b9d30892eed0c2b379aaf359686c6810b97cc4 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.mm
@@ -626,9 +626,6 @@ void CachePosition(CGFloat position, BookmarkMenuItem* item) {
cacheForMenuItemFolderWithPosition:position
folderId:item.folder->id()];
break;
- case bookmarks::MenuItemAll:
- cache = [BookmarkPositionCache cacheForMenuItemAllWithPosition:position];
- break;
case bookmarks::MenuItemDivider:
case bookmarks::MenuItemSectionHeader:
NOTREACHED();
@@ -659,11 +656,6 @@ BOOL GetPositionCache(bookmarks::BookmarkModel* model,
return NO;
switch (cache.type) {
- case bookmarks::MenuItemAll:
- if (!experimental_flags::IsAllBookmarksEnabled())
- return NO;
- *item = [BookmarkMenuItem allMenuItem];
- break;
case bookmarks::MenuItemFolder: {
const BookmarkNode* bookmark = FindFolderById(model, cache.folderId);
if (!bookmark)

Powered by Google App Engine
This is Rietveld 408576698