Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Unified Diff: components/sync/PRESUBMIT.py

Issue 2662453008: [Sync] Fix sync lint errors/includes, update presubmit. (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/browser_sync/PRESUBMIT.py ('k') | components/sync/base/hash_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/PRESUBMIT.py
diff --git a/components/sync/PRESUBMIT.py b/components/sync/PRESUBMIT.py
index b9b669f7be151dfa7def85e517c6c12109d36e47..276449b4a40d52ef50f644a703b0a95210e7f9aa 100644
--- a/components/sync/PRESUBMIT.py
+++ b/components/sync/PRESUBMIT.py
@@ -61,6 +61,10 @@ MODEL_TYPE_FILE_NAME = 'model_type.cc'
SYNC_SOURCE_FILES = (r'^components[\\/]sync[\\/].*\.(cc|h)$',)
+# The wrapper around lint that is called below disables a set of filters if the
+# passed filter evaluates to false. Pass a junk filter to avoid this behavior.
+LINT_FILTERS = ['+fake/filter']
+
def CheckModelTypeInfoMap(input_api, output_api, model_type_file):
"""Checks the kModelTypeInfoMap in model_type.cc follows conventions.
Checks that the kModelTypeInfoMap follows the below rules:
@@ -366,9 +370,9 @@ def FieldNumberToPrototypeString(field_number):
def CheckChangeLintsClean(input_api, output_api):
source_filter = lambda x: input_api.FilterSourceFile(
x, white_list=SYNC_SOURCE_FILES, black_list=None)
-
return input_api.canned_checks.CheckChangeLintsClean(
- input_api, output_api, source_filter, lint_filters=[], verbose_level=1)
+ input_api, output_api, source_filter, lint_filters=LINT_FILTERS,
+ verbose_level=1)
def CheckChanges(input_api, output_api):
results = []
« no previous file with comments | « components/browser_sync/PRESUBMIT.py ('k') | components/sync/base/hash_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698