Clang format slam.

Clang format slam.

BUG=None

[mmenke, 2014-10-10 18:12:26]

mmenke@chromium.org changed reviewers:
+ mmenke@chromium.org

[mmenke, 2014-10-10 18:12:40]

A couple comments about random sources of ugliness, now that we're seriously
considering enabling a presubmit check.

https://codereview.chromium.org/266243004/diff/1/net/base/mime_sniffer.cc
File net/base/mime_sniffer.cc (right):

https://codereview.chromium.org/266243004/diff/1/net/base/mime_sniffer.cc#new...
net/base/mime_sniffer.cc:122: ,
Hrm...That comma change is really weird.

https://codereview.chromium.org/266243004/diff/1/net/base/mime_sniffer.cc#new...
net/base/mime_sniffer.cc:200: MAGIC_NUMBER("OOXML", "PK\x03\x04")};
Not putting the close brace on its own line seems like a pretty big change.

https://codereview.chromium.org/266243004/diff/1/net/base/mime_sniffer.cc#new...
net/base/mime_sniffer.cc:639: 0) {
Think this is pretty ugly - I find no extra indent in cases like these,
particularly when there's both an == and || in the if body, very confusing.

https://codereview.chromium.org/266243004/diff/1/net/base/mime_sniffer.cc#new...
net/base/mime_sniffer.cc:647: return true;
This is a style violation - when an if body takes up multiple lines, there
should be braces.  Or at least that was the consensus on Chromium dev.

https://codereview.chromium.org/266243004/diff/1/net/base/mime_sniffer.cc#new...
net/base/mime_sniffer.cc:842: [] = {// Many web servers are misconfigured to
send text/plain for
Just no.

https://codereview.chromium.org/266243004/diff/1/net/base/mime_sniffer_unitte...
File net/base/mime_sniffer_unittest.cc (right):

https://codereview.chromium.org/266243004/diff/1/net/base/mime_sniffer_unitte...
net/base/mime_sniffer_unittest.cc:233: 1,
Confusing indentation here, methinks.

https://codereview.chromium.org/266243004/diff/1/net/base/mime_sniffer_unitte...
net/base/mime_sniffer_unittest.cc:418: 1,
Line split completely not needed.

https://codereview.chromium.org/266243004/diff/1/net/base/mime_util.cc
File net/base/mime_util.cc (right):

https://codereview.chromium.org/266243004/diff/1/net/base/mime_util.cc#newcod...
net/base/mime_util.cc:253: "image/png",                "image/gif",  
"image/bmp",
This is kinda weird.

https://codereview.chromium.org/266243004/diff/1/net/base/mime_util_unittest.cc
File net/base/mime_util_unittest.cc (right):

https://codereview.chromium.org/266243004/diff/1/net/base/mime_util_unittest....
net/base/mime_util_unittest.cc:24: };
This (And all cases like it) are pretty hideous.  I'd say we should get rid of
all cases of this, if we reformat files that do it.

[pauljensen, 2014-10-10 18:15:33]

This CL is >5 months old.  I believe Will filed several clang format bugs about
things seen here.  Might be a good idea to rerun it before looking too closely.

[mmenke, 2014-10-10 18:18:00]

On 2014/10/10 18:15:33, pauljensen wrote:
> This CL is >5 months old.  I believe Will filed several clang format bugs
about
> things seen here.  Might be a good idea to rerun it before looking too
closely.

SGTM.  May be worth reformatting some files, taking them through review, see how
things look, and if all goes well, only then adding the presubmit check.  Then
can reformat the rest.

[mmenke, 2015-02-27 20:36:36]

mmenke@chromium.org changed reviewers:
- mmenke@chromium.org