| Index: net/cert/ct_objects_extractor_unittest.cc
|
| diff --git a/net/cert/ct_objects_extractor_unittest.cc b/net/cert/ct_objects_extractor_unittest.cc
|
| index b229a478ae9e632480984092cca51af39b6a28e0..75fcc2e9db87952e2bb3158fcdd38451ac7867e6 100644
|
| --- a/net/cert/ct_objects_extractor_unittest.cc
|
| +++ b/net/cert/ct_objects_extractor_unittest.cc
|
| @@ -130,34 +130,34 @@ TEST_F(CTObjectsExtractorTest, ExtractSCTListFromOCSPResponse) {
|
| X509Certificate::CreateFromBytes(der_subject_cert.data(),
|
| der_subject_cert.length());
|
| std::string der_issuer_cert(ct::GetDerEncodedFakeOCSPResponseIssuerCert());
|
| - scoped_refptr<X509Certificate> issuer_cert =
|
| - X509Certificate::CreateFromBytes(der_issuer_cert.data(),
|
| - der_issuer_cert.length());
|
| + scoped_refptr<X509Certificate> issuer_cert = X509Certificate::CreateFromBytes(
|
| + der_issuer_cert.data(), der_issuer_cert.length());
|
|
|
| std::string fake_sct_list = ct::GetFakeOCSPExtensionValue();
|
| ASSERT_FALSE(fake_sct_list.empty());
|
| std::string ocsp_response = ct::GetDerEncodedFakeOCSPResponse();
|
|
|
| std::string extracted_sct_list;
|
| - EXPECT_TRUE(ct::ExtractSCTListFromOCSPResponse(
|
| - issuer_cert->os_cert_handle(), subject_cert->serial_number(),
|
| - ocsp_response, &extracted_sct_list));
|
| + EXPECT_TRUE(ct::ExtractSCTListFromOCSPResponse(issuer_cert->os_cert_handle(),
|
| + subject_cert->serial_number(),
|
| + ocsp_response,
|
| + &extracted_sct_list));
|
| EXPECT_EQ(extracted_sct_list, fake_sct_list);
|
| }
|
|
|
| // Test that the extractor honours serial number.
|
| TEST_F(CTObjectsExtractorTest, ExtractSCTListFromOCSPResponseMatchesSerial) {
|
| std::string der_issuer_cert(ct::GetDerEncodedFakeOCSPResponseIssuerCert());
|
| - scoped_refptr<X509Certificate> issuer_cert =
|
| - X509Certificate::CreateFromBytes(der_issuer_cert.data(),
|
| - der_issuer_cert.length());
|
| + scoped_refptr<X509Certificate> issuer_cert = X509Certificate::CreateFromBytes(
|
| + der_issuer_cert.data(), der_issuer_cert.length());
|
|
|
| std::string ocsp_response = ct::GetDerEncodedFakeOCSPResponse();
|
|
|
| std::string extracted_sct_list;
|
| - EXPECT_FALSE(ct::ExtractSCTListFromOCSPResponse(
|
| - issuer_cert->os_cert_handle(), test_cert_->serial_number(),
|
| - ocsp_response, &extracted_sct_list));
|
| + EXPECT_FALSE(ct::ExtractSCTListFromOCSPResponse(issuer_cert->os_cert_handle(),
|
| + test_cert_->serial_number(),
|
| + ocsp_response,
|
| + &extracted_sct_list));
|
| }
|
|
|
| // Test that the extractor honours issuer ID.
|
| @@ -171,9 +171,10 @@ TEST_F(CTObjectsExtractorTest, ExtractSCTListFromOCSPResponseMatchesIssuer) {
|
|
|
| std::string extracted_sct_list;
|
| // Use test_cert_ for issuer - it is not the correct issuer of |subject_cert|.
|
| - EXPECT_FALSE(ct::ExtractSCTListFromOCSPResponse(
|
| - test_cert_->os_cert_handle(), subject_cert->serial_number(),
|
| - ocsp_response, &extracted_sct_list));
|
| + EXPECT_FALSE(ct::ExtractSCTListFromOCSPResponse(test_cert_->os_cert_handle(),
|
| + subject_cert->serial_number(),
|
| + ocsp_response,
|
| + &extracted_sct_list));
|
| }
|
|
|
| } // namespace ct
|
|
|