Move const ResourceProvider members into Settings struct

Move const ResourceProvider members into Settings struct

Currently, ResourceProvider members which are set once at init and never
modified are not clearly identified. This makes it hard to see what
members can be used in a threadsafe manner.

This change moves these members to a Settings struct and makes the
settings "const", making it clearer how these may be used.

R=vmpstr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2662303004
Cr-Commit-Position: refs/heads/master@{#447906}
Committed: https://chromium.googlesource.com/chromium/src/+/a6e7079b7f5fe5448c8dd47f4cb991d56dbf6bb5

[ericrk, 2017-02-01 19:40:52]

Description was changed from

==========
Move const ResourceProvider members into Settings struct

Currently, ResourceProvider members which are set once at init and never
modified are not clearly identified. This makes it hard to see what
members can be used in a threadsafe manner.

This change moves these members to a Settings struct and makes the
settings "const", making it clearer how these may be used.

R=vmpstr@chromium.org
==========

to

==========
Move const ResourceProvider members into Settings struct

Currently, ResourceProvider members which are set once at init and never
modified are not clearly identified. This makes it hard to see what
members can be used in a threadsafe manner.

This change moves these members to a Settings struct and makes the
settings "const", making it clearer how these may be used.

R=vmpstr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmpstr, 2017-02-01 21:06:11]

lgtm

https://codereview.chromium.org/2662303004/diff/20001/cc/resources/resource_p...
File cc/resources/resource_provider.h (right):

https://codereview.chromium.org/2662303004/diff/20001/cc/resources/resource_p...
cc/resources/resource_provider.h:739: const Settings settings_;
const struct Settings {
  ...
} settings_;

or

struct Settings {
  ...
} const settings_;?

[ericrk, 2017-02-01 21:20:05]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2017-02-01 21:20:06]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2662303004/#ps40001
(title: "feedback")

[ericrk, 2017-02-01 21:20:10]

https://codereview.chromium.org/2662303004/diff/20001/cc/resources/resource_p...
File cc/resources/resource_provider.h (right):

https://codereview.chromium.org/2662303004/diff/20001/cc/resources/resource_p...
cc/resources/resource_provider.h:739: const Settings settings_;
On 2017/02/01 21:06:11, vmpstr wrote:
> const struct Settings {
>   ...
> } settings_;
> 
> or
> 
> struct Settings {
>   ...
> } const settings_;?

sgtm

[commit-bot: I haz the power, 2017-02-01 21:20:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 21:32:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 21:33:00]

Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[ericrk, 2017-02-01 21:59:44]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2017-02-01 21:59:44]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2662303004/#ps60001
(title: "fix init order")

[commit-bot: I haz the power, 2017-02-01 22:00:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 22:31:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 22:31:08]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[ericrk, 2017-02-01 23:11:34]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2017-02-01 23:12:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 23:26:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 23:26:59]

Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)

[ericrk, 2017-02-02 23:54:51]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2017-02-02 23:54:51]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2662303004/#ps80001
(title: "fix build")

[commit-bot: I haz the power, 2017-02-02 23:55:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 03:38:09]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486079691716670,
"parent_rev": "b69c81cc077bc63f12c61a46528dff5ce22e9985", "commit_rev":
"a6e7079b7f5fe5448c8dd47f4cb991d56dbf6bb5"}

[commit-bot: I haz the power, 2017-02-03 03:38:46]

Description was changed from

==========
Move const ResourceProvider members into Settings struct

Currently, ResourceProvider members which are set once at init and never
modified are not clearly identified. This makes it hard to see what
members can be used in a threadsafe manner.

This change moves these members to a Settings struct and makes the
settings "const", making it clearer how these may be used.

R=vmpstr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move const ResourceProvider members into Settings struct

Currently, ResourceProvider members which are set once at init and never
modified are not clearly identified. This makes it hard to see what
members can be used in a threadsafe manner.

This change moves these members to a Settings struct and makes the
settings "const", making it clearer how these may be used.

R=vmpstr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2662303004
Cr-Commit-Position: refs/heads/master@{#447906}
Committed:
https://chromium.googlesource.com/chromium/src/+/a6e7079b7f5fe5448c8dd47f4cb9...
==========

[commit-bot: I haz the power, 2017-02-03 03:38:47]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a6e7079b7f5fe5448c8dd47f4cb9...