Issue 2662153004: Don't update main thread scroll reasons on a throttled frame.

Issue 2662153004: Don't update main thread scroll reasons on a throttled frame. (Closed)

Created:
3 years, 10 months ago by szager1

Modified:
3 years, 10 months ago

Reviewers:
skobes

CC:
chromium-reviews, blink-reviews

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Don't update main thread scroll reasons on a throttled frame. When a frame is throttled, its compositing state cannot be queried, so don't try to set main thread scrolling reasons. This fixes DCHECK failures when root layer scrolling is enabled. BUG=490942 TEST=FrameThrottlingTest with RLS enabled R=skobes@chromium.org Review-Url: https://codereview.chromium.org/2662153004 Cr-Commit-Position: refs/heads/master@{#447962} Committed: https://chromium.googlesource.com/chromium/src/+/579fbe58da5d55ad7799df4a7b09df3dcde568fa

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	third_party/WebKit/Source/core/frame/FrameView.cpp	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Depends on Patchset:

Dependent Patchsets:

Total messages: 7 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662153004/1

3 years, 10 months ago (2017-02-03 06:47:14 UTC) #4

commit-bot: I haz the power

3 years, 10 months ago (2017-02-03 08:34:18 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/579fbe58da5d55ad7799df4a7b09...