Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2664083005: [Root Layer Scrolls] Fix touch event rect clearing. (Closed)

Created:
3 years, 10 months ago by szager1
Modified:
3 years, 10 months ago
Reviewers:
skobes
CC:
chromium-reviews, blink-layers+watch_chromium.org, kenneth.christiansen, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Root Layer Scrolls] Fix touch event rect clearing. When RLS is enabled, the code that clears out obsolete touch event rects can miss clearing rects on the root layer's main graphics layer backing if something caused the root layer to overflow. Here's the scenario: - Frame does not overflow. - Touch event handler is registered. - ScrollingCoordinator annotates touch event rects to the root layer's graphicsLayerBacking, which is its main graphics layer backing, because it doesn't overflow. - Something is added to make the frame overflow. - Touch event rects are removed from the root layer's graphicsLayerBacking, which is now the scrolling content layer. The main graphics layer backing, which has a touch event rect from the previous frame, is not modified, so keeps its old touch event rect. This patch ensures that touch rects are cleared on both the main graphics layer and the scrolling contents layer. BUG=490942 R=skobes@chromium.org TEST=FrameThrottlingTest with RLS enabled Review-Url: https://codereview.chromium.org/2664083005 Cr-Commit-Position: refs/heads/master@{#448362} Committed: https://chromium.googlesource.com/chromium/src/+/1af92770ce1315465a635bb797dd501b97d883bc

Patch Set 1 #

Total comments: 1

Patch Set 2 : variable renames #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 2 chunks +20 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
szager1
3 years, 10 months ago (2017-01-31 22:45:59 UTC) #1
skobes
lgtm w/ nit https://codereview.chromium.org/2664083005/diff/1/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp File third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp (right): https://codereview.chromium.org/2664083005/diff/1/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp#newcode749 third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp:749: GraphicsLayer* ownGraphicsLayer = I'd call these ...
3 years, 10 months ago (2017-02-03 04:29:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664083005/20001
3 years, 10 months ago (2017-02-06 18:27:50 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 20:04:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1af92770ce1315465a635bb797dd...

Powered by Google App Engine
This is Rietveld 408576698