Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2662003002: Fix a bug where PIXEL_UNPACK_BUFFER is cleared but never restored. (Closed)

Created:
3 years, 10 months ago by Kai Ninomiya
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Fix a bug where PIXEL_UNPACK_BUFFER is cleared but never restored. BUG=673929 TEST=test case from the bug R=kbr@chromium.org,kainino@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2652653003 Cr-Commit-Position: refs/heads/master@{#445640} (cherry picked from commit 6932383d121be06d4c40094b7f44b99026d2c396) Review-Url: https://codereview.chromium.org/2662003002 . Cr-Commit-Position: refs/branch-heads/2987@{#194} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/e6ff7696c74146965b4f7e083bf3d29e02f104c7

Patch Set 1 #

Patch Set 2 : Fix a bug where PIXEL_UNPACK_BUFFER is cleared but never restored. #

Patch Set 3 : Fix a bug where PIXEL_UNPACK_BUFFER is cleared but never restored. #

Patch Set 4 : Fix a bug where PIXEL_UNPACK_BUFFER is cleared but never restored. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662003002/1
3 years, 10 months ago (2017-01-30 20:25:51 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-01-30 20:25:52 UTC) #4
Kai Ninomiya
3 years, 10 months ago (2017-01-30 22:04:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
e6ff7696c74146965b4f7e083bf3d29e02f104c7.

Powered by Google App Engine
This is Rietveld 408576698