Fix a bug where PIXEL_UNPACK_BUFFER is cleared but never restored.

Fix a bug where PIXEL_UNPACK_BUFFER is cleared but never restored.

BUG=673929
TEST=test case from the bug
R=kbr@chromium.org,kainino@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2652653003
Cr-Commit-Position: refs/heads/master@{#445640}
Committed: https://chromium.googlesource.com/chromium/src/+/6932383d121be06d4c40094b7f44b99026d2c396

[Zhenyao Mo, 2017-01-23 23:20:19]

Description was changed from

==========
Fix a bug where PIXEL_UNPACK_BUFFER is cleared but never restored.

BUG=673929
TEST=test case from the bug
R=kbr@chromium.org,kainino@chromium.org
==========

to

==========
Fix a bug where PIXEL_UNPACK_BUFFER is cleared but never restored.

BUG=673929
TEST=test case from the bug
R=kbr@chromium.org,kainino@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2017-01-23 23:20:30]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 23:21:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2017-01-24 00:13:12]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 00:14:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2017-01-24 00:28:03]

A conformance is added in https://github.com/KhronosGroup/WebGL/pull/2271

It crashes without this CL and runs OK with this CL.

PTAL

[Ken Russell (switch to Gerrit), 2017-01-24 00:40:56]

Great catch Mo. LGTM

https://codereview.chromium.org/2652653003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2652653003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:1593: //
This query returns client side cached binding, so it's trivia.
Typo: trivia -> trivial

[Kai Ninomiya, 2017-01-24 00:45:02]

lgtm

[Zhenyao Mo, 2017-01-24 00:59:34]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2017-01-24 00:59:34]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
kainino@chromium.org
Link to the patchset: https://codereview.chromium.org/2652653003/#ps40001
(title: "typo")

[commit-bot: I haz the power, 2017-01-24 01:00:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 04:22:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485219574492920,
"parent_rev": "284fe71823b4516ac5630addd2f44788347ddd07", "commit_rev":
"6932383d121be06d4c40094b7f44b99026d2c396"}

[commit-bot: I haz the power, 2017-01-24 04:23:42]

Description was changed from

==========
Fix a bug where PIXEL_UNPACK_BUFFER is cleared but never restored.

BUG=673929
TEST=test case from the bug
R=kbr@chromium.org,kainino@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix a bug where PIXEL_UNPACK_BUFFER is cleared but never restored.

BUG=673929
TEST=test case from the bug
R=kbr@chromium.org,kainino@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2652653003
Cr-Commit-Position: refs/heads/master@{#445640}
Committed:
https://chromium.googlesource.com/chromium/src/+/6932383d121be06d4c40094b7f44...
==========

[commit-bot: I haz the power, 2017-01-24 04:23:43]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6932383d121be06d4c40094b7f44...