chrome/renderer/net/net_error_helper.h - Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad(

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/net/net_error_helper.h

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)

Patch Set: Remove CHECK for redirect chain as the redirects may not be populated for provisional loads for ren… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/net/net_error_helper.h

diff --git a/chrome/renderer/net/net_error_helper.h b/chrome/renderer/net/net_error_helper.h

index bc7fc80e4af17e95d901f85422ccc0d7770c4f55..3e04f883df3c8203220bb0d5a02fdb8b55584b5b 100644

--- a/chrome/renderer/net/net_error_helper.h

+++ b/chrome/renderer/net/net_error_helper.h

@@ -56,7 +56,7 @@ class NetErrorHelper

void TrackClick(int tracking_id) override;

// RenderFrameObserver implementation.

- void DidStartProvisionalLoad() override;

+ void DidStartProvisionalLoad(blink::WebDataSource* data_source) override;

void DidCommitProvisionalLoad(bool is_new_navigation,

bool is_same_page_navigation) override;

void DidFinishLoad() override;