Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: chrome/renderer/net/net_error_helper.cc

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)
Patch Set: Remove CHECK for redirect chain as the redirects may not be populated for provisional loads for ren… Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/net/net_error_helper.cc
diff --git a/chrome/renderer/net/net_error_helper.cc b/chrome/renderer/net/net_error_helper.cc
index 1c3d935d64b2ba5825f33e89f7510f5eea9962ea..e8ee1d95d9c6ee094e121db7dcc8ddc2f5764041 100644
--- a/chrome/renderer/net/net_error_helper.cc
+++ b/chrome/renderer/net/net_error_helper.cc
@@ -66,9 +66,9 @@ namespace {
// suggestions. If it takes too long, just use the local error page.
const int kNavigationCorrectionFetchTimeoutSec = 3;
-NetErrorHelperCore::PageType GetLoadingPageType(RenderFrame* render_frame) {
- blink::WebFrame* web_frame = render_frame->GetWebFrame();
- GURL url = web_frame->provisionalDataSource()->getRequest().url();
+NetErrorHelperCore::PageType GetLoadingPageType(
+ blink::WebDataSource* data_source) {
+ GURL url = data_source->getRequest().url();
if (!url.is_valid() || url.spec() != kUnreachableWebDataURL)
return NetErrorHelperCore::NON_ERROR_PAGE;
return NetErrorHelperCore::ERROR_PAGE;
@@ -118,9 +118,10 @@ void NetErrorHelper::TrackClick(int tracking_id) {
core_->TrackClick(tracking_id);
}
-void NetErrorHelper::DidStartProvisionalLoad() {
+void NetErrorHelper::DidStartProvisionalLoad(
+ blink::WebDataSource* data_source) {
core_->OnStartLoad(GetFrameType(render_frame()),
- GetLoadingPageType(render_frame()));
+ GetLoadingPageType(data_source));
}
void NetErrorHelper::DidCommitProvisionalLoad(bool is_new_navigation,
« no previous file with comments | « chrome/renderer/net/net_error_helper.h ('k') | components/autofill/content/renderer/password_autofill_agent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698