chrome/renderer/chrome_render_frame_observer.cc - Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad(

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_render_frame_observer.cc

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)

Patch Set: Remove CHECK for redirect chain as the redirects may not be populated for provisional loads for ren… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/chrome_render_frame_observer.cc

diff --git a/chrome/renderer/chrome_render_frame_observer.cc b/chrome/renderer/chrome_render_frame_observer.cc

index 23026a014e14c366416f43cf915d8f2cacca7946..729e75b33b0d1226356cf5c05b26a404246f02d2 100644

--- a/chrome/renderer/chrome_render_frame_observer.cc

+++ b/chrome/renderer/chrome_render_frame_observer.cc

@@ -251,7 +251,8 @@ void ChromeRenderFrameObserver::DidFinishLoad() {

}

-void ChromeRenderFrameObserver::DidStartProvisionalLoad() {

+void ChromeRenderFrameObserver::DidStartProvisionalLoad(

+ blink::WebDataSource* data_source) {

// Let translate_helper do any preparatory work for loading a URL.

if (!translate_helper_)

return;