Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1332)

Side by Side Diff: chrome/renderer/net/net_error_helper.h

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)
Patch Set: Remove CHECK for redirect chain as the redirects may not be populated for provisional loads for ren… Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_NET_NET_ERROR_HELPER_H_ 5 #ifndef CHROME_RENDERER_NET_NET_ERROR_HELPER_H_
6 #define CHROME_RENDERER_NET_NET_ERROR_HELPER_H_ 6 #define CHROME_RENDERER_NET_NET_ERROR_HELPER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 public chrome::mojom::NetworkDiagnosticsClient { 49 public chrome::mojom::NetworkDiagnosticsClient {
50 public: 50 public:
51 explicit NetErrorHelper(content::RenderFrame* render_frame); 51 explicit NetErrorHelper(content::RenderFrame* render_frame);
52 ~NetErrorHelper() override; 52 ~NetErrorHelper() override;
53 53
54 // NetErrorPageController::Delegate implementation 54 // NetErrorPageController::Delegate implementation
55 void ButtonPressed(error_page::NetErrorHelperCore::Button button) override; 55 void ButtonPressed(error_page::NetErrorHelperCore::Button button) override;
56 void TrackClick(int tracking_id) override; 56 void TrackClick(int tracking_id) override;
57 57
58 // RenderFrameObserver implementation. 58 // RenderFrameObserver implementation.
59 void DidStartProvisionalLoad() override; 59 void DidStartProvisionalLoad(blink::WebDataSource* data_source) override;
60 void DidCommitProvisionalLoad(bool is_new_navigation, 60 void DidCommitProvisionalLoad(bool is_new_navigation,
61 bool is_same_page_navigation) override; 61 bool is_same_page_navigation) override;
62 void DidFinishLoad() override; 62 void DidFinishLoad() override;
63 void OnStop() override; 63 void OnStop() override;
64 void WasShown() override; 64 void WasShown() override;
65 void WasHidden() override; 65 void WasHidden() override;
66 void OnDestruct() override; 66 void OnDestruct() override;
67 67
68 // IPC::Listener implementation. 68 // IPC::Listener implementation.
69 bool OnMessageReceived(const IPC::Message& message) override; 69 bool OnMessageReceived(const IPC::Message& message) override;
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 // Weak factory for vending a weak pointer to a NetErrorPageController. Weak 145 // Weak factory for vending a weak pointer to a NetErrorPageController. Weak
146 // pointers are invalidated on each commit, to prevent getting messages from 146 // pointers are invalidated on each commit, to prevent getting messages from
147 // Controllers used for the previous commit that haven't yet been cleaned up. 147 // Controllers used for the previous commit that haven't yet been cleaned up.
148 base::WeakPtrFactory<NetErrorPageController::Delegate> 148 base::WeakPtrFactory<NetErrorPageController::Delegate>
149 weak_controller_delegate_factory_; 149 weak_controller_delegate_factory_;
150 150
151 DISALLOW_COPY_AND_ASSIGN(NetErrorHelper); 151 DISALLOW_COPY_AND_ASSIGN(NetErrorHelper);
152 }; 152 };
153 153
154 #endif // CHROME_RENDERER_NET_NET_ERROR_HELPER_H_ 154 #endif // CHROME_RENDERER_NET_NET_ERROR_HELPER_H_
OLDNEW
« no previous file with comments | « chrome/renderer/chrome_render_frame_observer.cc ('k') | chrome/renderer/net/net_error_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698