Rename LocalFrameId to LocalSurfaceId

Rename LocalFrameId to LocalSurfaceId

LocalFrameId is a confusing name because it implies it uniquely identifies a
CompositorFrame but in reality multiple frames can be submitted to the same surface
with the same LocalFrameId. LocalFrameId only changes when a new surface is
needed (such as on resize), and therefore we believe LocalSurfaceId would
be a better name for it. So SurfaceId is the global identifier for a surface, and 
LocalSurfaceId can be thought of as the local identifier.

TBR=jam@chromium.org
TBR=tsepez@chromium.org

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2661543002
Cr-Commit-Position: refs/heads/master@{#446771}
Committed: https://chromium.googlesource.com/chromium/src/+/5258bfb4395abf16fca17a6c8fc09ff052eaf845

[Saman Sami, 2017-01-27 01:32:49]

Description was changed from

==========
Test

BUG=685765
==========

to

==========
Test

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-01-27 01:32:50]

Description was changed from

==========
Test

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Test

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-01-27 01:34:29]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 01:35:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 01:47:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 01:47:33]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Saman Sami, 2017-01-27 02:04:32]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 02:05:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 02:19:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 02:19:42]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Saman Sami, 2017-01-27 02:56:24]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 02:57:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 03:00:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 03:00:58]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Saman Sami, 2017-01-27 03:09:05]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 03:09:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 03:20:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 03:20:20]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Saman Sami, 2017-01-27 04:21:42]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 04:22:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 04:35:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 04:35:46]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Saman Sami, 2017-01-27 15:06:09]

Description was changed from

==========
Test

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Rename LocalFrameId to LocalSurfaceId

LocalFrameId is a confusing name because it implies it uniquely identifies a
CompositorFrame but in reality multiple frames can be submitted to the same
surface
with the same LocalFrameId. LocalFrameId only changes when a new surface is
needed (such as on resize), and therefore we believe LocalSurfaceId would
be a better name for it. So SurfaceId will be the global identifier for a
surface, and 
LocalSurfaceId can be thought of as a local identifier.

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-01-27 15:07:01]

Description was changed from

==========
Rename LocalFrameId to LocalSurfaceId

LocalFrameId is a confusing name because it implies it uniquely identifies a
CompositorFrame but in reality multiple frames can be submitted to the same
surface
with the same LocalFrameId. LocalFrameId only changes when a new surface is
needed (such as on resize), and therefore we believe LocalSurfaceId would
be a better name for it. So SurfaceId will be the global identifier for a
surface, and 
LocalSurfaceId can be thought of as a local identifier.

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Rename LocalFrameId to LocalSurfaceId

LocalFrameId is a confusing name because it implies it uniquely identifies a
CompositorFrame but in reality multiple frames can be submitted to the same
surface
with the same LocalFrameId. LocalFrameId only changes when a new surface is
needed (such as on resize), and therefore we believe LocalSurfaceId would
be a better name for it. So SurfaceId is the global identifier for a surface,
and 
LocalSurfaceId can be thought of as the local identifier.

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-01-27 15:07:02]

samans@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Saman Sami, 2017-01-27 15:07:20]

PTAL

[Fady Samuel, 2017-01-27 15:09:28]

lgtm

[Saman Sami, 2017-01-27 15:12:54]

samans@chromium.org changed reviewers:
+ darin@chromium.org

[Saman Sami, 2017-01-27 15:13:22]

samans@chromium.org changed reviewers:
+ tsepez@chromium.org

[Saman Sami, 2017-01-27 15:15:02]

Description was changed from

==========
Rename LocalFrameId to LocalSurfaceId

LocalFrameId is a confusing name because it implies it uniquely identifies a
CompositorFrame but in reality multiple frames can be submitted to the same
surface
with the same LocalFrameId. LocalFrameId only changes when a new surface is
needed (such as on resize), and therefore we believe LocalSurfaceId would
be a better name for it. So SurfaceId is the global identifier for a surface,
and 
LocalSurfaceId can be thought of as the local identifier.

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Rename LocalFrameId to LocalSurfaceId

LocalFrameId is a confusing name because it implies it uniquely identifies a
CompositorFrame but in reality multiple frames can be submitted to the same
surface
with the same LocalFrameId. LocalFrameId only changes when a new surface is
needed (such as on resize), and therefore we believe LocalSurfaceId would
be a better name for it. So SurfaceId is the global identifier for a surface,
and 
LocalSurfaceId can be thought of as the local identifier.

TBR=darin@chromium.org, tsepez@chromium.org

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-01-27 15:20:01]

Description was changed from

==========
Rename LocalFrameId to LocalSurfaceId

LocalFrameId is a confusing name because it implies it uniquely identifies a
CompositorFrame but in reality multiple frames can be submitted to the same
surface
with the same LocalFrameId. LocalFrameId only changes when a new surface is
needed (such as on resize), and therefore we believe LocalSurfaceId would
be a better name for it. So SurfaceId is the global identifier for a surface,
and 
LocalSurfaceId can be thought of as the local identifier.

TBR=darin@chromium.org, tsepez@chromium.org

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Rename LocalFrameId to LocalSurfaceId

LocalFrameId is a confusing name because it implies it uniquely identifies a
CompositorFrame but in reality multiple frames can be submitted to the same
surface
with the same LocalFrameId. LocalFrameId only changes when a new surface is
needed (such as on resize), and therefore we believe LocalSurfaceId would
be a better name for it. So SurfaceId is the global identifier for a surface,
and 
LocalSurfaceId can be thought of as the local identifier.

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-01-27 15:20:01]

samans@chromium.org changed reviewers:
+ danakj@chromium.org
- darin@chromium.org, tsepez@chromium.org

[Saman Sami, 2017-01-27 15:20:24]

danakj@: Please review all files.

[Saman Sami, 2017-01-27 15:22:21]

Description was changed from

==========
Rename LocalFrameId to LocalSurfaceId

LocalFrameId is a confusing name because it implies it uniquely identifies a
CompositorFrame but in reality multiple frames can be submitted to the same
surface
with the same LocalFrameId. LocalFrameId only changes when a new surface is
needed (such as on resize), and therefore we believe LocalSurfaceId would
be a better name for it. So SurfaceId is the global identifier for a surface,
and 
LocalSurfaceId can be thought of as the local identifier.

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Rename LocalFrameId to LocalSurfaceId

LocalFrameId is a confusing name because it implies it uniquely identifies a
CompositorFrame but in reality multiple frames can be submitted to the same
surface
with the same LocalFrameId. LocalFrameId only changes when a new surface is
needed (such as on resize), and therefore we believe LocalSurfaceId would
be a better name for it. So SurfaceId is the global identifier for a surface,
and 
LocalSurfaceId can be thought of as the local identifier.

TBR=jam@chromium.org

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-01-27 15:22:21]

samans@chromium.org changed reviewers:
+ jam@chromium.org

[Saman Sami, 2017-01-27 15:22:49]

Description was changed from

==========
Rename LocalFrameId to LocalSurfaceId

LocalFrameId is a confusing name because it implies it uniquely identifies a
CompositorFrame but in reality multiple frames can be submitted to the same
surface
with the same LocalFrameId. LocalFrameId only changes when a new surface is
needed (such as on resize), and therefore we believe LocalSurfaceId would
be a better name for it. So SurfaceId is the global identifier for a surface,
and 
LocalSurfaceId can be thought of as the local identifier.

TBR=jam@chromium.org

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Rename LocalFrameId to LocalSurfaceId

LocalFrameId is a confusing name because it implies it uniquely identifies a
CompositorFrame but in reality multiple frames can be submitted to the same
surface
with the same LocalFrameId. LocalFrameId only changes when a new surface is
needed (such as on resize), and therefore we believe LocalSurfaceId would
be a better name for it. So SurfaceId is the global identifier for a surface,
and 
LocalSurfaceId can be thought of as the local identifier.

TBR=jam@chromium.org, tsepez@chromium.org

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-01-27 15:22:49]

samans@chromium.org changed reviewers:
+ tsepez@chromium.org

[danakj, 2017-01-27 16:25:17]

I spotchecked a few files, LGTM

https://codereview.chromium.org/2661543002/diff/60001/cc/surfaces/local_surfa...
File cc/surfaces/local_surface_id.cc (right):

https://codereview.chromium.org/2661543002/diff/60001/cc/surfaces/local_surfa...
cc/surfaces/local_surface_id.cc:1: // Copyright 2016 The Chromium Authors. All
rights reserved.
2017

https://codereview.chromium.org/2661543002/diff/60001/cc/surfaces/local_surfa...
File cc/surfaces/local_surface_id.h (right):

https://codereview.chromium.org/2661543002/diff/60001/cc/surfaces/local_surfa...
cc/surfaces/local_surface_id.h:1: // Copyright 2016 The Chromium Authors. All
rights reserved.
2017 in new files

[Saman Sami, 2017-01-27 16:33:17]

The CQ bit was checked by samans@chromium.org

[Saman Sami, 2017-01-27 16:33:18]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2661543002/#ps80001
(title: "c")

[commit-bot: I haz the power, 2017-01-27 16:33:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 16:42:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 16:42:10]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Saman Sami, 2017-01-27 16:49:36]

Description was changed from

==========
Rename LocalFrameId to LocalSurfaceId

LocalFrameId is a confusing name because it implies it uniquely identifies a
CompositorFrame but in reality multiple frames can be submitted to the same
surface
with the same LocalFrameId. LocalFrameId only changes when a new surface is
needed (such as on resize), and therefore we believe LocalSurfaceId would
be a better name for it. So SurfaceId is the global identifier for a surface,
and 
LocalSurfaceId can be thought of as the local identifier.

TBR=jam@chromium.org, tsepez@chromium.org

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Rename LocalFrameId to LocalSurfaceId

LocalFrameId is a confusing name because it implies it uniquely identifies a
CompositorFrame but in reality multiple frames can be submitted to the same
surface
with the same LocalFrameId. LocalFrameId only changes when a new surface is
needed (such as on resize), and therefore we believe LocalSurfaceId would
be a better name for it. So SurfaceId is the global identifier for a surface,
and 
LocalSurfaceId can be thought of as the local identifier.

TBR=jam@chromium.org

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Tom Sepez, 2017-01-27 17:17:30]

lgtm

[Saman Sami, 2017-01-27 17:18:43]

The CQ bit was checked by samans@chromium.org

[commit-bot: I haz the power, 2017-01-27 17:19:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 17:29:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 17:29:20]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2017-01-27 17:51:15]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2017-01-27 17:51:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 18:01:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 18:01:33]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2017-01-27 18:04:12]

Description was changed from

==========
Rename LocalFrameId to LocalSurfaceId

LocalFrameId is a confusing name because it implies it uniquely identifies a
CompositorFrame but in reality multiple frames can be submitted to the same
surface
with the same LocalFrameId. LocalFrameId only changes when a new surface is
needed (such as on resize), and therefore we believe LocalSurfaceId would
be a better name for it. So SurfaceId is the global identifier for a surface,
and 
LocalSurfaceId can be thought of as the local identifier.

TBR=jam@chromium.org

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Rename LocalFrameId to LocalSurfaceId

LocalFrameId is a confusing name because it implies it uniquely identifies a
CompositorFrame but in reality multiple frames can be submitted to the same
surface
with the same LocalFrameId. LocalFrameId only changes when a new surface is
needed (such as on resize), and therefore we believe LocalSurfaceId would
be a better name for it. So SurfaceId is the global identifier for a surface,
and 
LocalSurfaceId can be thought of as the local identifier.

TBR=jam@chromium.org
TBR=tsepez@chromium.org

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2017-01-27 18:04:22]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2017-01-27 18:04:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 18:13:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 18:13:51]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Saman Sami, 2017-01-27 18:56:54]

The CQ bit was checked by samans@chromium.org

[Saman Sami, 2017-01-27 18:56:55]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
fsamuel@chromium.org, tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2661543002/#ps100001
(title: "c")

[commit-bot: I haz the power, 2017-01-27 18:57:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-01-27 19:19:12]

Patchset #7 (id:120001) has been deleted

[Saman Sami, 2017-01-27 19:20:00]

The CQ bit was checked by samans@chromium.org

[Saman Sami, 2017-01-27 19:20:00]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
fsamuel@chromium.org, tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2661543002/#ps100001
(title: "c")

[commit-bot: I haz the power, 2017-01-27 19:20:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 21:16:31]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485544800236670,
"parent_rev": "dc974fef99b96b1a153fa7e7c35949de285c7e67", "commit_rev":
"5258bfb4395abf16fca17a6c8fc09ff052eaf845"}

[commit-bot: I haz the power, 2017-01-27 21:17:04]

Description was changed from

==========
Rename LocalFrameId to LocalSurfaceId

LocalFrameId is a confusing name because it implies it uniquely identifies a
CompositorFrame but in reality multiple frames can be submitted to the same
surface
with the same LocalFrameId. LocalFrameId only changes when a new surface is
needed (such as on resize), and therefore we believe LocalSurfaceId would
be a better name for it. So SurfaceId is the global identifier for a surface,
and 
LocalSurfaceId can be thought of as the local identifier.

TBR=jam@chromium.org
TBR=tsepez@chromium.org

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Rename LocalFrameId to LocalSurfaceId

LocalFrameId is a confusing name because it implies it uniquely identifies a
CompositorFrame but in reality multiple frames can be submitted to the same
surface
with the same LocalFrameId. LocalFrameId only changes when a new surface is
needed (such as on resize), and therefore we believe LocalSurfaceId would
be a better name for it. So SurfaceId is the global identifier for a surface,
and 
LocalSurfaceId can be thought of as the local identifier.

TBR=jam@chromium.org
TBR=tsepez@chromium.org

BUG=685765
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2661543002
Cr-Commit-Position: refs/heads/master@{#446771}
Committed:
https://chromium.googlesource.com/chromium/src/+/5258bfb4395abf16fca17a6c8fc0...
==========

[commit-bot: I haz the power, 2017-01-27 21:17:07]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/5258bfb4395abf16fca17a6c8fc0...