third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp - Issue 2661543002: Rename LocalFrameId to LocalSurfaceId

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp

Issue 2661543002: Rename LocalFrameId to LocalSurfaceId (Closed)

Patch Set: c Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h ('k') | third_party/WebKit/public/blink_typemaps.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp b/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp

index 6e8a5cd4022250ee0f93ab8aebf72b179be895bd..a88f8c2a8232db41ad1b7f0f61a01b79f5c58129 100644

--- a/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp

+++ b/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp

@@ -48,7 +48,7 @@ OffscreenCanvasFrameDispatcherImpl::OffscreenCanvasFrameDispatcherImpl(

m_nextResourceId(1u),

m_binding(this),

m_placeholderCanvasId(canvasId) {

- m_currentLocalFrameId = m_surfaceIdAllocator.GenerateId();

+ m_currentLocalSurfaceId = m_surfaceIdAllocator.GenerateId();

DCHECK(!m_sink.is_bound());

mojom::blink::OffscreenCanvasCompositorFrameSinkProviderPtr provider;

Platform::current()->interfaceProvider()->getInterface(

@@ -368,10 +368,10 @@ void OffscreenCanvasFrameDispatcherImpl::dispatchFrame(

}

if (m_changeSizeForNextCommit) {

- m_currentLocalFrameId = m_surfaceIdAllocator.GenerateId();

+ m_currentLocalSurfaceId = m_surfaceIdAllocator.GenerateId();

m_changeSizeForNextCommit = false;

}

- m_sink->SubmitCompositorFrame(m_currentLocalFrameId, std::move(frame));

+ m_sink->SubmitCompositorFrame(m_currentLocalSurfaceId, std::move(frame));

// TODO(crbug.com/674744): Get BeginFrame to fire on its own.

scheduleSyntheticBeginFrame();