content/browser/renderer_host/offscreen_canvas_surface_manager_unittest.cc - Issue 2661543002: Rename LocalFrameId to LocalSurfaceId

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/offscreen_canvas_surface_manager_unittest.cc

Issue 2661543002: Rename LocalFrameId to LocalSurfaceId (Closed)

Patch Set: c Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/offscreen_canvas_surface_impl.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/offscreen_canvas_surface_manager_unittest.cc

diff --git a/content/browser/renderer_host/offscreen_canvas_surface_manager_unittest.cc b/content/browser/renderer_host/offscreen_canvas_surface_manager_unittest.cc

index 104228ed48b810a42acdb2e7307673e1d1a9c222..48253882848cd056e5d58c4d4002ee755d76b9f0 100644

--- a/content/browser/renderer_host/offscreen_canvas_surface_manager_unittest.cc

+++ b/content/browser/renderer_host/offscreen_canvas_surface_manager_unittest.cc

@@ -72,7 +72,8 @@ TEST_F(OffscreenCanvasSurfaceManagerTest,

blink::mojom::OffscreenCanvasSurfaceClientPtr client;

cc::FrameSinkId frame_sink_id(3, 3);

cc::SurfaceIdAllocator surface_id_allocator;

- cc::LocalFrameId current_local_frame_id(surface_id_allocator.GenerateId());

+ cc::LocalSurfaceId current_local_surface_id(

+ surface_id_allocator.GenerateId());

auto surface_impl = base::WrapUnique(

new OffscreenCanvasSurfaceImpl(frame_sink_id, std::move(client)));

@@ -81,8 +82,9 @@ TEST_F(OffscreenCanvasSurfaceManagerTest,

OffscreenCanvasSurfaceManager::GetInstance()->GetSurfaceInstance(

frame_sink_id));

- this->OnSurfaceCreated(cc::SurfaceId(frame_sink_id, current_local_frame_id));

- EXPECT_EQ(current_local_frame_id, surface_impl->current_local_frame_id());

+ this->OnSurfaceCreated(

+ cc::SurfaceId(frame_sink_id, current_local_surface_id));

+ EXPECT_EQ(current_local_surface_id, surface_impl->current_local_surface_id());

surface_impl = nullptr;

EXPECT_EQ(0, this->getNumSurfaceImplInstances());