Split ios/chrome/app/startup targets to reduce dependencies.

ios/chrome/app/startup/BUILD.gn

Index: ios/chrome/app/startup/BUILD.gn
diff --git a/ios/chrome/app/startup/BUILD.gn b/ios/chrome/app/startup/BUILD.gn
index 71c1a1970efdb81f2ccbc0aadd03abfdf974b8ed..2e99d8a79ff92926056c64c41685974abb5b49d1 100644
--- a/ios/chrome/app/startup/BUILD.gn
+++ b/ios/chrome/app/startup/BUILD.gn
@@ -4,22 +4,15 @@
 
 import("//ios/public/provider/chrome/browser/build_config.gni")
 
-source_set("startup") {
+# Target for sources that don't depend on //ios/chrome/browser

[sdefresne, 2017/02/01 14:01:02]

I was going to suggest enforcing this with assert_no_deps (see "gn help
assert_no_deps") but it looks like the target do depends on
//ios/chrome/browser:chrome_paths. Is the comment misleading ? I interpreted it
as no dependencies on "//ios/chrome/browser/*" but maybe you meant exactly
"//ios/chrome/browser:browser".

If the former, then I think the comment is incorrect. If the latter, then you
can add the following to the target to enforce it:

  assert_no_deps = [ "//ios/chrome/browser" ]

Or if you don't want the dependency on anything below "//ios/chrome/browser",
that would be

  assert_no_deps = [ "//ios/chrome/browser/*" ]

but then you'll have to remove the dependency on
"//ios/chrome/browser:chrome_paths" too.

[marq (ping after 24h), 2017/05/03 15:27:27]

I meant browser:browser. Added the assertion.

+source_set("startup_basic") {
   sources = [
-    "background_upload_alert.h",
-    "background_upload_alert.mm",
     "chrome_main_starter.h",
     "chrome_main_starter.mm",
-    "client_registration.h",
-    "client_registration.mm",
     "ios_chrome_main.h",
     "ios_chrome_main.mm",
     "ios_chrome_main_delegate.h",
     "ios_chrome_main_delegate.mm",
-    "network_stack_setup.h",
-    "network_stack_setup.mm",
-    "provider_registration.h",
-    "provider_registration.mm",
     "register_experimental_settings.h",
     "register_experimental_settings.mm",
     "setup_debugging.h",
@@ -29,6 +22,27 @@ source_set("startup") {
   deps = [
     "//base",
     "//components/crash/core/common",
+    "//ios/chrome/browser:chrome_paths",
+    "//ios/web/public/app",
+    "//skia",
+  ]
+}
+
+source_set("startup") {
+  sources = [
+    "background_upload_alert.h",
+    "background_upload_alert.mm",
+    "client_registration.h",
+    "client_registration.mm",
+    "network_stack_setup.h",
+    "network_stack_setup.mm",
+    "provider_registration.h",
+    "provider_registration.mm",
+  ]
+
+  deps = [
+    ":startup_basic",
+    "//base",
     "//ios/chrome/browser",
     "//ios/chrome/browser:browser_internal",
     "//ios/chrome/browser/web",
@@ -37,7 +51,6 @@ source_set("startup") {
     "//ios/public/provider/chrome/browser",
     "//ios/web",
     "//ios/web/public/app",
-    "//skia",
     ios_provider_target,
   ]
 }