Split ios/chrome/app/startup targets to reduce dependencies.

Split ios/chrome/app/startup targets to reduce dependencies.

This CL splits the startup targets to separate those without
/ios/chrome/browser/ dependencies. Showcase would prefer not to have a
large dependency tree, so it uses the startup_basic target.

This change removes ~2000 build steps from a clean Showcase build, but
chrome_paths still transitively depends on several large components
(sync, etc) even though it's only getting a single constant from gcm_driver.

BUG=

Review-Url: https://codereview.chromium.org/2661183002
Cr-Commit-Position: refs/heads/master@{#470304}
Committed: https://chromium.googlesource.com/chromium/src/+/21be5ad542a27e814f797c3cbe774d1d606fe0b3

[marq (ping after 24h), 2017-01-31 13:05:34]

marq@chromium.org changed reviewers:
+ sczs@chromium.org, sdefresne@chromium.org

[marq (ping after 24h), 2017-01-31 13:05:35]

sczs: FYI

[marq (ping after 24h), 2017-01-31 13:05:40]

The CQ bit was checked by marq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 13:05:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 13:11:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 13:11:43]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sdefresne, 2017-01-31 15:06:49]

On 2017/01/31 13:05:35, marq wrote:
> sczs: FYI

You probably need to fix the dependencies or add startup_basic as a public_deps
of startup.

[marq (ping after 24h), 2017-02-01 12:19:23]

Description was changed from

==========
Split ios/chrome/app/startup targets to reduce dependencies.

This CL splits the startup targets to separate those without
/ios/chrome/browser/ dependencies. Showcase would prefer not to have a
large dependency tree, so it uses the startup_basic target.

BUG=
==========

to

==========
Split ios/chrome/app/startup targets to reduce dependencies.

This CL splits the startup targets to separate those without
/ios/chrome/browser/ dependencies. Showcase would prefer not to have a
large dependency tree, so it uses the startup_basic target.

This change removes ~2000 build steps from a clean Showcase build, but
chrome_paths still transitively depends on several large components (sync, etc)
even though it's only getting a single constant from gcm_driver.

BUG=
==========

[marq (ping after 24h), 2017-02-01 12:19:30]

The CQ bit was checked by marq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 12:19:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marq (ping after 24h), 2017-02-01 12:19:58]

Description was changed from

==========
Split ios/chrome/app/startup targets to reduce dependencies.

This CL splits the startup targets to separate those without
/ios/chrome/browser/ dependencies. Showcase would prefer not to have a
large dependency tree, so it uses the startup_basic target.

This change removes ~2000 build steps from a clean Showcase build, but
chrome_paths still transitively depends on several large components (sync, etc)
even though it's only getting a single constant from gcm_driver.

BUG=
==========

to

==========
Split ios/chrome/app/startup targets to reduce dependencies.

This CL splits the startup targets to separate those without
/ios/chrome/browser/ dependencies. Showcase would prefer not to have a
large dependency tree, so it uses the startup_basic target.

This change removes ~2000 build steps from a clean Showcase build, but
chrome_paths still transitively depends on several large components
(sync, etc) even though it's only getting a single constant from gcm_driver.

BUG=
==========

[marq (ping after 24h), 2017-02-01 12:20:10]

Thanks, PTAL.

[commit-bot: I haz the power, 2017-02-01 13:38:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 13:38:18]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-02-01 14:01:02]

lgtm with one question/comment

https://codereview.chromium.org/2661183002/diff/20001/ios/chrome/app/startup/...
File ios/chrome/app/startup/BUILD.gn (right):

https://codereview.chromium.org/2661183002/diff/20001/ios/chrome/app/startup/...
ios/chrome/app/startup/BUILD.gn:7: # Target for sources that don't depend on
//ios/chrome/browser
I was going to suggest enforcing this with assert_no_deps (see "gn help
assert_no_deps") but it looks like the target do depends on
//ios/chrome/browser:chrome_paths. Is the comment misleading ? I interpreted it
as no dependencies on "//ios/chrome/browser/*" but maybe you meant exactly
"//ios/chrome/browser:browser".

If the former, then I think the comment is incorrect. If the latter, then you
can add the following to the target to enforce it:

  assert_no_deps = [ "//ios/chrome/browser" ]

Or if you don't want the dependency on anything below "//ios/chrome/browser",
that would be

  assert_no_deps = [ "//ios/chrome/browser/*" ]

but then you'll have to remove the dependency on
"//ios/chrome/browser:chrome_paths" too.

https://codereview.chromium.org/2661183002/diff/20001/ios/chrome/browser/BUIL...
File ios/chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/2661183002/diff/20001/ios/chrome/browser/BUIL...
ios/chrome/browser/BUILD.gn:93: public_deps = [
nit: can you put public_deps after deps (and without blank lines for consistency
with the rest of the BUILD.gn files in //ios)?

[sdefresne, 2017-05-03 09:12:51]

What is the status of this CL? Should it land? Should it be closed?

[marq (ping after 24h), 2017-05-03 15:27:27]

Resurrected. PTAL.

https://codereview.chromium.org/2661183002/diff/20001/ios/chrome/app/startup/...
File ios/chrome/app/startup/BUILD.gn (right):

https://codereview.chromium.org/2661183002/diff/20001/ios/chrome/app/startup/...
ios/chrome/app/startup/BUILD.gn:7: # Target for sources that don't depend on
//ios/chrome/browser
On 2017/02/01 14:01:02, sdefresne wrote:
> I was going to suggest enforcing this with assert_no_deps (see "gn help
> assert_no_deps") but it looks like the target do depends on
> //ios/chrome/browser:chrome_paths. Is the comment misleading ? I interpreted
it
> as no dependencies on "//ios/chrome/browser/*" but maybe you meant exactly
> "//ios/chrome/browser:browser".
> 
> If the former, then I think the comment is incorrect. If the latter, then you
> can add the following to the target to enforce it:
> 
>   assert_no_deps = [ "//ios/chrome/browser" ]
> 
> Or if you don't want the dependency on anything below "//ios/chrome/browser",
> that would be
> 
>   assert_no_deps = [ "//ios/chrome/browser/*" ]
> 
> but then you'll have to remove the dependency on
> "//ios/chrome/browser:chrome_paths" too.

I meant browser:browser. Added the assertion.

https://codereview.chromium.org/2661183002/diff/20001/ios/chrome/browser/BUIL...
File ios/chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/2661183002/diff/20001/ios/chrome/browser/BUIL...
ios/chrome/browser/BUILD.gn:93: public_deps = [
On 2017/02/01 14:01:02, sdefresne wrote:
> nit: can you put public_deps after deps (and without blank lines for
consistency
> with the rest of the BUILD.gn files in //ios)?

Done.

[marq (ping after 24h), 2017-05-09 07:40:07]

The CQ bit was checked by marq@chromium.org

[marq (ping after 24h), 2017-05-09 07:40:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2661183002/#ps40001
(title: "Review feedback, rebase.")

[commit-bot: I haz the power, 2017-05-09 07:40:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-05-09 07:49:12]

lgtm

[commit-bot: I haz the power, 2017-05-09 11:41:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 11:41:31]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[marq (ping after 24h), 2017-05-09 12:27:15]

The CQ bit was checked by marq@chromium.org

[commit-bot: I haz the power, 2017-05-09 12:27:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 13:20:42]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494332835962630,
"parent_rev": "e03263581463ff17960eef46c3173bb28d9e3b8e", "commit_rev":
"21be5ad542a27e814f797c3cbe774d1d606fe0b3"}

[commit-bot: I haz the power, 2017-05-09 13:20:54]

Description was changed from

==========
Split ios/chrome/app/startup targets to reduce dependencies.

This CL splits the startup targets to separate those without
/ios/chrome/browser/ dependencies. Showcase would prefer not to have a
large dependency tree, so it uses the startup_basic target.

This change removes ~2000 build steps from a clean Showcase build, but
chrome_paths still transitively depends on several large components
(sync, etc) even though it's only getting a single constant from gcm_driver.

BUG=
==========

to

==========
Split ios/chrome/app/startup targets to reduce dependencies.

This CL splits the startup targets to separate those without
/ios/chrome/browser/ dependencies. Showcase would prefer not to have a
large dependency tree, so it uses the startup_basic target.

This change removes ~2000 build steps from a clean Showcase build, but
chrome_paths still transitively depends on several large components
(sync, etc) even though it's only getting a single constant from gcm_driver.

BUG=

Review-Url: https://codereview.chromium.org/2661183002
Cr-Commit-Position: refs/heads/master@{#470304}
Committed:
https://chromium.googlesource.com/chromium/src/+/21be5ad542a27e814f797c3cbe77...
==========

[commit-bot: I haz the power, 2017-05-09 13:20:56]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/21be5ad542a27e814f797c3cbe77...