ios/chrome/app/BUILD.gn - Issue 2661183002: Split ios/chrome/app/startup targets to reduce dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/app/BUILD.gn

Issue 2661183002: Split ios/chrome/app/startup targets to reduce dependencies. (Closed)

Patch Set: Fixed dependencies, factored out chrome_paths. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/app/BUILD.gn

diff --git a/ios/chrome/app/BUILD.gn b/ios/chrome/app/BUILD.gn

index 9b17b928557cf0fe0e151e2ceb8433986ada1f4f..64c91322d349ea96be56d79d413cb78556324a71 100644

--- a/ios/chrome/app/BUILD.gn

+++ b/ios/chrome/app/BUILD.gn

@@ -162,6 +162,7 @@ source_set("app_internal") {

"//ios/chrome/app/safe_mode",

"//ios/chrome/app/spotlight",

"//ios/chrome/app/startup",

+ "//ios/chrome/app/startup:startup_basic",

"//ios/chrome/app/strings",

"//ios/chrome/browser",

"//ios/chrome/browser:browser_internal",

@@ -252,7 +253,7 @@ source_set("main") {

":app_internal",

"//base",

"//components/crash/core/common",

- "//ios/chrome/app/startup",

+ "//ios/chrome/app/startup:startup_basic",

"//ios/chrome/browser:browser_internal",

"//ios/chrome/browser/crash_report",

"//ios/chrome/common",

« no previous file with comments | « no previous file | ios/chrome/app/startup/BUILD.gn » ('j') | ios/chrome/app/startup/BUILD.gn » ('J')