Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: ios/chrome/browser/BUILD.gn

Issue 2661183002: Split ios/chrome/app/startup targets to reduce dependencies. (Closed)
Patch Set: Fixed dependencies, factored out chrome_paths. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/BUILD.gn
diff --git a/ios/chrome/browser/BUILD.gn b/ios/chrome/browser/BUILD.gn
index 7e026166fa35672f3533ed54a5b2d7ed0f7bd8e9..5a414acff5c550463e029d378c4b4a7ce705f76e 100644
--- a/ios/chrome/browser/BUILD.gn
+++ b/ios/chrome/browser/BUILD.gn
@@ -21,6 +21,20 @@ declare_args() {
google_test_sync_url = ""
}
+source_set("chrome_paths") {
+ configs += [ "//build/config/compiler:enable_arc" ]
+ sources = [
+ "chrome_paths.h",
+ "chrome_paths.mm",
+ "chrome_paths_internal.h",
+ ]
+
+ deps = [
+ "//base",
+ "//components/gcm_driver",
+ ]
+}
+
source_set("browser") {
configs += [ "//build/config/compiler:enable_arc" ]
sources = [
@@ -38,9 +52,6 @@ source_set("browser") {
"chrome_constants.h",
"chrome_coordinator.h",
"chrome_coordinator.mm",
- "chrome_paths.h",
- "chrome_paths.mm",
- "chrome_paths_internal.h",
"chrome_switches.cc",
"chrome_switches.h",
"chrome_url_constants.cc",
@@ -78,6 +89,11 @@ source_set("browser") {
"xcallback_parameters.h",
"xcallback_parameters.mm",
]
+
+ public_deps = [
sdefresne 2017/02/01 14:01:02 nit: can you put public_deps after deps (and witho
marq (ping after 24h) 2017/05/03 15:27:27 Done.
+ ":chrome_paths",
+ ]
+
deps = [
":google_api_keys_header",
":settings_resources",
@@ -87,7 +103,6 @@ source_set("browser") {
"//components/dom_distiller/core",
"//components/flags_ui",
"//components/flags_ui:switches",
- "//components/gcm_driver",
"//components/handoff",
"//components/keyed_service/core",
"//components/keyed_service/ios",

Powered by Google App Engine
This is Rietveld 408576698