Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1450)

Side by Side Diff: ios/chrome/browser/BUILD.gn

Issue 2661183002: Split ios/chrome/app/startup targets to reduce dependencies. (Closed)
Patch Set: Fixed dependencies, factored out chrome_paths. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/features.gni") 6 import("//build/config/features.gni")
7 import("//build/config/ios/rules.gni") 7 import("//build/config/ios/rules.gni")
8 import("//rlz/features/features.gni") 8 import("//rlz/features/features.gni")
9 import("//third_party/protobuf/proto_library.gni") 9 import("//third_party/protobuf/proto_library.gni")
10 10
11 declare_args() { 11 declare_args() {
12 google_test_gaia_client_id = "" 12 google_test_gaia_client_id = ""
13 google_test_gaia_client_secret = "" 13 google_test_gaia_client_secret = ""
14 google_staging_api_url = "" 14 google_staging_api_url = ""
15 google_staging_lso_url = "" 15 google_staging_lso_url = ""
16 google_test_api_url = "" 16 google_test_api_url = ""
17 google_test_lso_url = "" 17 google_test_lso_url = ""
18 google_test_oauth_client_id = "" 18 google_test_oauth_client_id = ""
19 google_test_oauth_client_secret = "" 19 google_test_oauth_client_secret = ""
20 google_test_oauth_url = "" 20 google_test_oauth_url = ""
21 google_test_sync_url = "" 21 google_test_sync_url = ""
22 } 22 }
23 23
24 source_set("chrome_paths") {
25 configs += [ "//build/config/compiler:enable_arc" ]
26 sources = [
27 "chrome_paths.h",
28 "chrome_paths.mm",
29 "chrome_paths_internal.h",
30 ]
31
32 deps = [
33 "//base",
34 "//components/gcm_driver",
35 ]
36 }
37
24 source_set("browser") { 38 source_set("browser") {
25 configs += [ "//build/config/compiler:enable_arc" ] 39 configs += [ "//build/config/compiler:enable_arc" ]
26 sources = [ 40 sources = [
27 "about_flags.h", 41 "about_flags.h",
28 "about_flags.mm", 42 "about_flags.mm",
29 "app_startup_parameters.h", 43 "app_startup_parameters.h",
30 "app_startup_parameters.mm", 44 "app_startup_parameters.mm",
31 "application_context.cc", 45 "application_context.cc",
32 "application_context.h", 46 "application_context.h",
33 "arch_util.cc", 47 "arch_util.cc",
34 "arch_util.h", 48 "arch_util.h",
35 "browser_about_rewriter.cc", 49 "browser_about_rewriter.cc",
36 "browser_about_rewriter.h", 50 "browser_about_rewriter.h",
37 "chrome_constants.cc", 51 "chrome_constants.cc",
38 "chrome_constants.h", 52 "chrome_constants.h",
39 "chrome_coordinator.h", 53 "chrome_coordinator.h",
40 "chrome_coordinator.mm", 54 "chrome_coordinator.mm",
41 "chrome_paths.h",
42 "chrome_paths.mm",
43 "chrome_paths_internal.h",
44 "chrome_switches.cc", 55 "chrome_switches.cc",
45 "chrome_switches.h", 56 "chrome_switches.h",
46 "chrome_url_constants.cc", 57 "chrome_url_constants.cc",
47 "chrome_url_constants.h", 58 "chrome_url_constants.h",
48 "chrome_url_util.h", 59 "chrome_url_util.h",
49 "chrome_url_util.mm", 60 "chrome_url_util.mm",
50 "crash_loop_detection_util.h", 61 "crash_loop_detection_util.h",
51 "crash_loop_detection_util.mm", 62 "crash_loop_detection_util.mm",
52 "experimental_flags.h", 63 "experimental_flags.h",
53 "experimental_flags.mm", 64 "experimental_flags.mm",
(...skipping 17 matching lines...) Expand all
71 "root_coordinator.h", 82 "root_coordinator.h",
72 "root_coordinator.mm", 83 "root_coordinator.mm",
73 "storekit_launcher.h", 84 "storekit_launcher.h",
74 "tab_parenting_global_observer.cc", 85 "tab_parenting_global_observer.cc",
75 "tab_parenting_global_observer.h", 86 "tab_parenting_global_observer.h",
76 "web_data_service_factory.cc", 87 "web_data_service_factory.cc",
77 "web_data_service_factory.h", 88 "web_data_service_factory.h",
78 "xcallback_parameters.h", 89 "xcallback_parameters.h",
79 "xcallback_parameters.mm", 90 "xcallback_parameters.mm",
80 ] 91 ]
92
93 public_deps = [
sdefresne 2017/02/01 14:01:02 nit: can you put public_deps after deps (and witho
marq (ping after 24h) 2017/05/03 15:27:27 Done.
94 ":chrome_paths",
95 ]
96
81 deps = [ 97 deps = [
82 ":google_api_keys_header", 98 ":google_api_keys_header",
83 ":settings_resources", 99 ":settings_resources",
84 "//base", 100 "//base",
85 "//components/autofill/core/browser", 101 "//components/autofill/core/browser",
86 "//components/autofill/core/common", 102 "//components/autofill/core/common",
87 "//components/dom_distiller/core", 103 "//components/dom_distiller/core",
88 "//components/flags_ui", 104 "//components/flags_ui",
89 "//components/flags_ui:switches", 105 "//components/flags_ui:switches",
90 "//components/gcm_driver",
91 "//components/handoff", 106 "//components/handoff",
92 "//components/keyed_service/core", 107 "//components/keyed_service/core",
93 "//components/keyed_service/ios", 108 "//components/keyed_service/ios",
94 "//components/metrics", 109 "//components/metrics",
95 "//components/metrics_services_manager", 110 "//components/metrics_services_manager",
96 "//components/net_log", 111 "//components/net_log",
97 "//components/network_session_configurator", 112 "//components/network_session_configurator",
98 "//components/ntp_tiles", 113 "//components/ntp_tiles",
99 "//components/pref_registry", 114 "//components/pref_registry",
100 "//components/prefs", 115 "//components/prefs",
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 264
250 source_set("browser_internal") { 265 source_set("browser_internal") {
251 sources = [ 266 sources = [
252 "callback_counter.h", 267 "callback_counter.h",
253 "callback_counter.mm", 268 "callback_counter.mm",
254 ] 269 ]
255 deps = [ 270 deps = [
256 "//base", 271 "//base",
257 ] 272 ]
258 } 273 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698