Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: ios/chrome/app/startup/BUILD.gn

Issue 2661183002: Split ios/chrome/app/startup targets to reduce dependencies. (Closed)
Patch Set: Review feedback, rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/app/BUILD.gn ('k') | ios/chrome/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/app/startup/BUILD.gn
diff --git a/ios/chrome/app/startup/BUILD.gn b/ios/chrome/app/startup/BUILD.gn
index 27c868d29f1a2b177105f87d2af36f2f831c9909..6a6c4855aa8fa6347f0385c1de1689e4559933da 100644
--- a/ios/chrome/app/startup/BUILD.gn
+++ b/ios/chrome/app/startup/BUILD.gn
@@ -4,32 +4,51 @@
import("//ios/public/provider/chrome/browser/build_config.gni")
-source_set("startup") {
- configs += [ "//build/config/compiler:enable_arc" ]
+# Target for sources that don't depend on //ios/chrome/browser:browser
+source_set("startup_basic") {
sources = [
- "background_upload_alert.h",
- "background_upload_alert.mm",
"chrome_main_starter.h",
"chrome_main_starter.mm",
- "client_registration.h",
- "client_registration.mm",
"ios_chrome_main.h",
"ios_chrome_main.mm",
"ios_chrome_main_delegate.h",
"ios_chrome_main_delegate.mm",
- "network_stack_setup.h",
- "network_stack_setup.mm",
- "provider_registration.h",
- "provider_registration.mm",
"register_experimental_settings.h",
"register_experimental_settings.mm",
"setup_debugging.h",
"setup_debugging.mm",
]
+ configs += [ "//build/config/compiler:enable_arc" ]
+
deps = [
"//base",
"//components/crash/core/common",
+ "//ios/chrome/browser:chrome_paths",
+ "//ios/web/public/app",
+ "//skia",
+ ]
+
+ assert_no_deps = [ "//ios/chrome/browser" ]
+}
+
+source_set("startup") {
+ sources = [
+ "background_upload_alert.h",
+ "background_upload_alert.mm",
+ "client_registration.h",
+ "client_registration.mm",
+ "network_stack_setup.h",
+ "network_stack_setup.mm",
+ "provider_registration.h",
+ "provider_registration.mm",
+ ]
+
+ configs += [ "//build/config/compiler:enable_arc" ]
+
+ deps = [
+ ":startup_basic",
+ "//base",
"//ios/chrome/browser",
"//ios/chrome/browser:browser_internal",
"//ios/chrome/browser/web",
@@ -38,7 +57,6 @@ source_set("startup") {
"//ios/public/provider/chrome/browser",
"//ios/web",
"//ios/web/public/app",
- "//skia",
ios_provider_target,
]
}
« no previous file with comments | « ios/chrome/app/BUILD.gn ('k') | ios/chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698