Make deleted bots still show up when searched for by id

Make deleted bots still show up when searched for by id

BUG=617846
Review-Url: https://codereview.chromium.org/2661173004
Committed: https://github.com/luci/luci-py/commit/a9f128b188adf70e29fbe768c3473f5f96489be2

[kjlubick, 2017-01-31 18:13:23]

kjlubick@google.com changed reviewers:
+ maruel@chromium.org, stephana@chromium.org

[kjlubick, 2017-01-31 18:13:24]

See it live at
https://2594-c0ba470-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/bot?...

https://screenshot.googleplex.com/ne0MQLco7rK

[M-A Ruel, 2017-01-31 18:45:04]

Thanks! Just a small change.

https://codereview.chromium.org/2661173004/diff/40001/appengine/swarming/hand...
File appengine/swarming/handlers_endpoints.py (right):

https://codereview.chromium.org/2661173004/diff/40001/appengine/swarming/hand...
appengine/swarming/handlers_endpoints.py:560: 
remove one line or even better both :)

https://codereview.chromium.org/2661173004/diff/40001/appengine/swarming/hand...
appengine/swarming/handlers_endpoints.py:586: return
message_conversion.bot_info_to_rpc(bot, utils.utcnow())
modify bot_info_to_rpc instead to accept a new flag deleted. It's cleaner IMHO.

https://codereview.chromium.org/2661173004/diff/40001/appengine/swarming/serv...
File appengine/swarming/server/bot_management.py (right):

https://codereview.chromium.org/2661173004/diff/40001/appengine/swarming/serv...
appengine/swarming/server/bot_management.py:164: # Was the bot deleted.
Don't make it a BooleanProperty, as it implies that the value should be
serialized. In practice it's not the case, so I prefer no change here.

[kjlubick, 2017-01-31 19:04:40]

https://codereview.chromium.org/2661173004/diff/40001/appengine/swarming/hand...
File appengine/swarming/handlers_endpoints.py (right):

https://codereview.chromium.org/2661173004/diff/40001/appengine/swarming/hand...
appengine/swarming/handlers_endpoints.py:560: 
On 2017/01/31 at 18:45:04, M-A Ruel wrote:
> remove one line or even better both :)

Done.

https://codereview.chromium.org/2661173004/diff/40001/appengine/swarming/hand...
appengine/swarming/handlers_endpoints.py:586: return
message_conversion.bot_info_to_rpc(bot, utils.utcnow())
On 2017/01/31 at 18:45:04, M-A Ruel wrote:
> modify bot_info_to_rpc instead to accept a new flag deleted. It's cleaner
IMHO.

Done.

https://codereview.chromium.org/2661173004/diff/40001/appengine/swarming/serv...
File appengine/swarming/server/bot_management.py (right):

https://codereview.chromium.org/2661173004/diff/40001/appengine/swarming/serv...
appengine/swarming/server/bot_management.py:164: # Was the bot deleted.
On 2017/01/31 at 18:45:04, M-A Ruel wrote:
> Don't make it a BooleanProperty, as it implies that the value should be
serialized. In practice it's not the case, so I prefer no change here.

done.

[M-A Ruel, 2017-01-31 21:54:38]

The CQ bit was checked by maruel@chromium.org

[M-A Ruel, 2017-01-31 21:54:39]

lgtm

[commit-bot: I haz the power, 2017-01-31 21:54:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 21:59:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485899678612560,
"parent_rev": "d319360fa0208c3f2e6b550d92d9ee4db7b3198a", "commit_rev":
"a9f128b188adf70e29fbe768c3473f5f96489be2"}

[commit-bot: I haz the power, 2017-01-31 21:59:43]

Description was changed from

==========
Make deleted bots still show up when searched for by id

BUG=617846
==========

to

==========
Make deleted bots still show up when searched for by id

BUG=617846

Review-Url: https://codereview.chromium.org/2661173004
Committed:
https://github.com/luci/luci-py/commit/a9f128b188adf70e29fbe768c3473f5f96489be2
==========

[commit-bot: I haz the power, 2017-01-31 21:59:44]

Committed patchset #4 (id:60001) as
https://github.com/luci/luci-py/commit/a9f128b188adf70e29fbe768c3473f5f96489be2