Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: appengine/swarming/ui/res/imp/botpage/bot-page.html

Issue 2661173004: Make deleted bots still show up when searched for by id (Closed)
Patch Set: Address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/swarming/ui/build/elements.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/swarming/ui/res/imp/botpage/bot-page.html
diff --git a/appengine/swarming/ui/res/imp/botpage/bot-page.html b/appengine/swarming/ui/res/imp/botpage/bot-page.html
index ca214dc531ddf1f2e096af0a765cfda4acb69eea..60defc69404ae4b82e754a39a03547def348651a 100644
--- a/appengine/swarming/ui/res/imp/botpage/bot-page.html
+++ b/appengine/swarming/ui/res/imp/botpage/bot-page.html
@@ -83,6 +83,11 @@
margin-top: auto;
}
+ .deleted {
+ text-align: center;
+ font-size: larger;
+ }
+
paper-checkbox {
--paper-checkbox-label-color: #fff;
--paper-checkbox-checked-color: #fff;
@@ -155,6 +160,12 @@
<div class="horizontal wrap layout">
<div class="flex">
<table>
+ <template is="dom-if" if="[[_bot.deleted]]">
+ <tr class="dead deleted" title="This bot was deleted.">
+ <td colspan=3>THIS BOT WAS DELETED</td>
+ </td>
+ </tr>
+ </template>
<tr class$="[[_isDead(_bot)]]" title="Last time the bot contacted the server.">
<td>Last Seen</td>
<td title="[[_bot.human_last_seen_ts]]">
@@ -441,15 +452,15 @@
},
_canCancel: function(bot, permissions) {
- return bot && bot.task_id && permissions.cancel_task;
+ return bot && bot.task_id && permissions.cancel_task && !bot.deleted;
},
_canDelete: function(bot, permissions) {
- return bot && bot.is_dead && permissions.delete_bot;
+ return bot && bot.is_dead && permissions.delete_bot && !bot.deleted;
},
_canShutdown: function(bot, permissions){
- return bot && !bot.is_dead && permissions.terminate_bot;
+ return bot && !bot.is_dead && permissions.terminate_bot && !bot.deleted;
},
_classVersion: function(serverVersion, otherVersion) {
@@ -503,7 +514,7 @@
},
_isDead(bot){
- if (bot && bot.is_dead) {
+ if (bot && bot.is_dead && !bot.deleted) {
return "dead";
}
return "";
« no previous file with comments | « appengine/swarming/ui/build/elements.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698