Make deleted bots still show up when searched for by id

appengine/swarming/server/bot_management.py

 # Copyright 2014 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 """Swarming bot management, e.g. list of known bots and their state.
 
           +---------+
           |BotRoot  |
           |id=bot_id|
           +---------+
@@ skipping 143 matching lines @@
   # Avoid having huge amounts of indices to query by quarantined/idle
   composite = ndb.ComputedProperty(lambda self: self._calc_composite(),
                                    repeated=True)
 
   def _calc_composite(self):
     return [
       self.QUARANTINED if self.quarantined else self.NOT_QUARANTINED,
       self.BUSY if self.task_id else self.NOT_BUSY
     ]
 
+  # Was the bot deleted.

[M-A Ruel, 2017/01/31 18:45:04]

Don't make it a BooleanProperty, as it implies that the value should be
serialized. In practice it's not the case, so I prefer no change here.

[kjlubick, 2017/01/31 19:04:40]

done.

+  deleted = ndb.BooleanProperty(default=False)
+
   @property
   def id(self):
     return self.key.parent().string_id()
 
   def is_dead(self, now):
     """Returns True if the bot is dead based on timestamp now."""
     timeout = config.settings().bot_death_timeout_secs
     return (now - self.last_seen_ts).total_seconds() >= timeout
 
   def to_dict(self, exclude=None):
@@ skipping 269 matching lines @@
   Returns:
     Tuple (True to restart, text message explaining the reason).
   """
   # Periodically reboot bots to workaround OS level leaks (especially on Win).
   running_time = state.get('running_time', 0)
   assert isinstance(running_time, (int, float))
   period = get_bot_reboot_period(bot_id, state)
   if period and running_time > period:
     return True, 'Periodic reboot: running longer than %ds' % period
   return False, ''