Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2661173003: [parser] Skipping inner funcs: add some more test cases which already pass. (Closed)

Created:
3 years, 10 months ago by marja
Modified:
3 years, 10 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Skipping inner funcs: add some more test cases which already pass. BUG=v8:5516 R=vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2661173003 Cr-Commit-Position: refs/heads/master@{#42825} Committed: https://chromium.googlesource.com/v8/v8/+/639bf4aa9cb6fe478a7a46e402344319c50e211a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M test/cctest/test-parsing.cc View 2 chunks +28 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
marja
some more trivial stuff, ptal
3 years, 10 months ago (2017-01-31 16:46:43 UTC) #1
vogelheim
lgtm
3 years, 10 months ago (2017-01-31 17:08:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661173003/1
3 years, 10 months ago (2017-01-31 21:15:12 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 21:41:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/639bf4aa9cb6fe478a7a46e402344319c50...

Powered by Google App Engine
This is Rietveld 408576698