Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2666053003: [scopes]: With --print-scopes, print preparsed scopes before destroying them. (Closed)

Created:
3 years, 10 months ago by marja
Modified:
3 years, 10 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[scopes]: With --print-scopes, print preparsed scopes before destroying them. BUG=v8:5516 Review-Url: https://codereview.chromium.org/2666053003 Cr-Commit-Position: refs/heads/master@{#42835} Committed: https://chromium.googlesource.com/v8/v8/+/f33cd98cd6b42901a54db893c061a7a1847e2269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/ast/scopes.cc View 3 chunks +11 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
marja
ptal
3 years, 10 months ago (2017-01-31 16:57:46 UTC) #2
vogelheim
lgtm
3 years, 10 months ago (2017-01-31 17:10:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666053003/1
3 years, 10 months ago (2017-02-01 07:13:37 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 07:39:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f33cd98cd6b42901a54db893c061a7a1847...

Powered by Google App Engine
This is Rietveld 408576698