Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 2663043003: [parser] Skipping inner funcs: make preparser scope analysis work w/ destructuring declarations. (Closed)

Created:
3 years, 10 months ago by marja
Modified:
3 years, 10 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Skipping inner funcs: make preparser scope analysis test work w/ destructuring declarations. If hidden scopes are ignored, the scopes and variable produced by the PreParser already matched the scopes and variables produced by the Parser. BUG=v8:5516 R=vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2663043003 Cr-Commit-Position: refs/heads/master@{#42824} Committed: https://chromium.googlesource.com/v8/v8/+/c03783f5f0e4462f264ebab5b51ecb7ce0893f20

Patch Set 1 #

Patch Set 2 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M test/cctest/test-parsing.cc View 1 3 chunks +36 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
marja
ptal
3 years, 10 months ago (2017-01-31 15:53:52 UTC) #2
vogelheim
lgtm
3 years, 10 months ago (2017-01-31 17:08:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663043003/20001
3 years, 10 months ago (2017-01-31 20:40:27 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 21:08:59 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c03783f5f0e4462f264ebab5b51ecb7ce08...

Powered by Google App Engine
This is Rietveld 408576698