Cronet: a framework to provide alternative Cronet implementations

Cronet: a framework to provide alternative Cronet implementations

1. Added CronetProvider interface (abstract class) that can be subclassed
   in order to add an alternative CronetEngineBuilder implementation.
   The interface is implemented by the new built-in Java and Native
   Cronet engine providers.

2. Provided functionality that can be used by an embedder to explicitly
   select the desired provider from the list of available ones. If the
   embedder doesn't select one. The system select the the best available
   one based on the provider versions and types.

3. Deprecated enableLegacyMode(). The embedder can now explicitly choose
   what implementation to use.

4. Changed the tests to use the new approach.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2626523003
Cr-Commit-Position: refs/heads/master@{#445561}
(cherry picked from commit 640977d34b03a64f019b3b9f25fb6e15820914a6)

BUG=686774
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2660963002
Cr-Commit-Position: refs/branch-heads/2987@{#199}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/12f8bc6c1361d506f51598da28696a6350b17954

[pauljensen, 2017-01-30 19:05:42]

pauljensen@chromium.org changed reviewers:
+ pauljensen@chromium.org

[pauljensen, 2017-01-30 19:05:42]

lgtm

[kapishnikov, 2017-01-30 22:35:12]

The CQ bit was checked by kapishnikov@chromium.org

[kapishnikov, 2017-01-30 22:35:44]

The CQ bit was unchecked by kapishnikov@chromium.org

[commit-bot: I haz the power, 2017-01-30 22:35:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 22:35:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 22:35:50]

CLs for remote refs other than refs/heads/master must contain NOTRY=true and
NOPRESUBMIT=true in order for the CQ to process them

[kapishnikov, 2017-01-30 22:36:12]

The CQ bit was checked by kapishnikov@chromium.org

[commit-bot: I haz the power, 2017-01-30 22:37:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 22:37:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 22:37:03]

CLs for remote refs other than refs/heads/master must contain NOTRY=true and
NOPRESUBMIT=true in order for the CQ to process them

[kapishnikov, 2017-01-30 22:45:36]

Description was changed from

==========
Cronet: a framework to provide alternative Cronet implementations

1. Added CronetProvider interface (abstract class) that can be subclassed
   in order to add an alternative CronetEngineBuilder implementation.
   The interface is implemented by the new built-in Java and Native
   Cronet engine providers.

2. Provided functionality that can be used by an embedder to explicitly
   select the desired provider from the list of available ones. If the
   embedder doesn't select one. The system select the the best available
   one based on the provider versions and types.

3. Deprecated enableLegacyMode(). The embedder can now explicitly choose
   what implementation to use.

4. Changed the tests to use the new approach.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2626523003
Cr-Commit-Position: refs/heads/master@{#445561}
(cherry picked from commit 640977d34b03a64f019b3b9f25fb6e15820914a6)

BUG=686774
==========

to

==========
Cronet: a framework to provide alternative Cronet implementations

1. Added CronetProvider interface (abstract class) that can be subclassed
   in order to add an alternative CronetEngineBuilder implementation.
   The interface is implemented by the new built-in Java and Native
   Cronet engine providers.

2. Provided functionality that can be used by an embedder to explicitly
   select the desired provider from the list of available ones. If the
   embedder doesn't select one. The system select the the best available
   one based on the provider versions and types.

3. Deprecated enableLegacyMode(). The embedder can now explicitly choose
   what implementation to use.

4. Changed the tests to use the new approach.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2626523003
Cr-Commit-Position: refs/heads/master@{#445561}
(cherry picked from commit 640977d34b03a64f019b3b9f25fb6e15820914a6)

BUG=686774
NOTRY=true
NOPRESUBMIT=true
==========

[kapishnikov, 2017-01-30 22:48:35]

The CQ bit was checked by kapishnikov@chromium.org

[commit-bot: I haz the power, 2017-01-30 22:49:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 22:50:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485816515891330, "parent_rev":
"cdf4402738b87ca888eb12baa02d1b78bd396b4a", "commit_rev":
"12f8bc6c1361d506f51598da28696a6350b17954"}

[commit-bot: I haz the power, 2017-01-30 22:51:07]

Description was changed from

==========
Cronet: a framework to provide alternative Cronet implementations

1. Added CronetProvider interface (abstract class) that can be subclassed
   in order to add an alternative CronetEngineBuilder implementation.
   The interface is implemented by the new built-in Java and Native
   Cronet engine providers.

2. Provided functionality that can be used by an embedder to explicitly
   select the desired provider from the list of available ones. If the
   embedder doesn't select one. The system select the the best available
   one based on the provider versions and types.

3. Deprecated enableLegacyMode(). The embedder can now explicitly choose
   what implementation to use.

4. Changed the tests to use the new approach.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2626523003
Cr-Commit-Position: refs/heads/master@{#445561}
(cherry picked from commit 640977d34b03a64f019b3b9f25fb6e15820914a6)

BUG=686774
NOTRY=true
NOPRESUBMIT=true
==========

to

==========
Cronet: a framework to provide alternative Cronet implementations

1. Added CronetProvider interface (abstract class) that can be subclassed
   in order to add an alternative CronetEngineBuilder implementation.
   The interface is implemented by the new built-in Java and Native
   Cronet engine providers.

2. Provided functionality that can be used by an embedder to explicitly
   select the desired provider from the list of available ones. If the
   embedder doesn't select one. The system select the the best available
   one based on the provider versions and types.

3. Deprecated enableLegacyMode(). The embedder can now explicitly choose
   what implementation to use.

4. Changed the tests to use the new approach.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2626523003
Cr-Commit-Position: refs/heads/master@{#445561}
(cherry picked from commit 640977d34b03a64f019b3b9f25fb6e15820914a6)

BUG=686774
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2660963002
Cr-Commit-Position: refs/branch-heads/2987@{#199}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/12f8bc6c1361d506f51598da2869...
==========

[commit-bot: I haz the power, 2017-01-30 22:51:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/12f8bc6c1361d506f51598da2869...