components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java - Issue 2660963002: Cronet: a framework to provide alternative Cronet implementations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java

Issue 2660963002: Cronet: a framework to provide alternative Cronet implementations (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/CronetEngineBuilderImpl.java ('k') | components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java

index 3b669b628796cfb7924a0ef7573613dd09d63adb..e45dd8f48030fa9a1ec74f60b118fd1b13f81f61 100644

--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java

+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java

@@ -47,13 +47,13 @@ public class CronetLibraryLoader {

System.loadLibrary(LIBRARY_NAME);

}

ContextUtils.initApplicationContextForNative();

- if (!ImplVersion.CRONET_VERSION.equals(nativeGetCronetVersion())) {

+ String implVersion = ImplVersion.getCronetVersion();

+ if (!implVersion.equals(nativeGetCronetVersion())) {

throw new RuntimeException(String.format("Expected Cronet version number %s, "

+ "actual version number %s.",

- ImplVersion.CRONET_VERSION, nativeGetCronetVersion()));

+ implVersion, nativeGetCronetVersion()));

}

- Log.i(TAG, "Cronet version: %s, arch: %s", ImplVersion.CRONET_VERSION,

- System.getProperty("os.arch"));

+ Log.i(TAG, "Cronet version: %s, arch: %s", implVersion, System.getProperty("os.arch"));

// Init native Chromium CronetEngine on Main UI thread.

Runnable task = new Runnable() {

@Override