Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: components/cronet/android/api/src/org/chromium/net/ExperimentalCronetEngine.java

Issue 2660963002: Cronet: a framework to provide alternative Cronet implementations (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/api/src/org/chromium/net/ExperimentalCronetEngine.java
diff --git a/components/cronet/android/api/src/org/chromium/net/ExperimentalCronetEngine.java b/components/cronet/android/api/src/org/chromium/net/ExperimentalCronetEngine.java
index 007166ee01f19d32534dc1c429ae220a8a129627..6d034ad1314621c3194827b479e625f156ddb3b4 100644
--- a/components/cronet/android/api/src/org/chromium/net/ExperimentalCronetEngine.java
+++ b/components/cronet/android/api/src/org/chromium/net/ExperimentalCronetEngine.java
@@ -89,6 +89,19 @@ public abstract class ExperimentalCronetEngine extends CronetEngine {
}
/**
+ * Constructs {@link Builder} with a given delegate that provides the actual implementation
+ * of the {@code Builder} methods. This constructor is used only by the internal
+ * implementation.
+ *
+ * @param builderDelegate delegate that provides the actual implementation.
+ *
+ * {@hide}
+ */
+ public Builder(ICronetEngineBuilder builderDelegate) {
+ super(builderDelegate);
+ }
+
+ /**
* Enables the network quality estimator, which collects and reports
* measurements of round trip time (RTT) and downstream throughput at
* various layers of the network stack. After enabling the estimator,
@@ -138,27 +151,6 @@ public abstract class ExperimentalCronetEngine extends CronetEngine {
}
/**
- * Sets whether the resulting {@link CronetEngine} uses an
- * implementation based on the system's
- * {@link java.net.HttpURLConnection} implementation, or if this is
- * only done as a backup if the native implementation fails to load.
- * Defaults to disabled.
- * @param value {@code true} makes the resulting {@link CronetEngine}
- * use an implementation based on the system's
- * {@link java.net.HttpURLConnection} implementation
- * without trying to load the native implementation.
- * {@code false} makes the resulting {@code CronetEngine}
- * use the native implementation, or if that fails to load,
- * falls back to an implementation based on the system's
- * {@link java.net.HttpURLConnection} implementation.
- * @return the builder to facilitate chaining.
- */
- public Builder enableLegacyMode(boolean value) {
- mBuilderDelegate.enableLegacyMode(value);
- return this;
- }
-
- /**
* Enables
* <a href="https://developer.chrome.com/multidevice/data-compression">Data
* Reduction Proxy</a>. Defaults to disabled.

Powered by Google App Engine
This is Rietveld 408576698