Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2660513002: Move delay before tapping tools menu to global location. (Closed)

Created:
3 years, 11 months ago by baxley
Modified:
3 years, 11 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move delay before tapping tools menu to global location. Multiple tests have been flaky, so moving it to the helper in ChromeEarlGreyUI, will see if this is the problem. BUG=685570 Review-Url: https://codereview.chromium.org/2660513002 Cr-Commit-Position: refs/heads/master@{#446450} Committed: https://chromium.googlesource.com/chromium/src/+/8fb5e88be8e7123c26507d88584399e6b237be1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -16 lines) Patch
M ios/chrome/browser/ui/history/history_ui_egtest.mm View 2 chunks +0 lines, -16 lines 0 comments Download
M ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
rohitrao (ping after 24h)
lgtm Per our conversation, let's try this and see if it gets rid of the ...
3 years, 11 months ago (2017-01-26 21:00:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660513002/1
3 years, 11 months ago (2017-01-26 21:03:48 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 21:20:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8fb5e88be8e7123c26507d885843...

Powered by Google App Engine
This is Rietveld 408576698