Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: ios/chrome/browser/ui/history/history_ui_egtest.mm

Issue 2660513002: Move delay before tapping tools menu to global location. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/history/history_ui_egtest.mm
diff --git a/ios/chrome/browser/ui/history/history_ui_egtest.mm b/ios/chrome/browser/ui/history/history_ui_egtest.mm
index 1614bd249da6d84c35fd507ee592cc267c596002..789923a87d8c4509e37650db4f6c7d855a378c30 100644
--- a/ios/chrome/browser/ui/history/history_ui_egtest.mm
+++ b/ios/chrome/browser/ui/history/history_ui_egtest.mm
@@ -218,14 +218,6 @@ void MockSignIn() {
// Tests that no history is shown if there has been no navigation.
- (void)testDisplayNoHistory {
- // TODO(crbug.com/685570): Fix the tap instead of adding a delay.
- GREYCondition* myCondition = [GREYCondition
- conditionWithName:@"Delay to ensure the toolbar menu can be opened"
- block:^BOOL {
- return NO;
- }];
- [myCondition waitWithTimeout:0.5];
-
[self openHistoryPanel];
[self assertNoHistoryShown];
}
@@ -451,14 +443,6 @@ void MockSignIn() {
// Navigates to history and checks elements for accessibility.
- (void)testAccessibilityOnHistory {
- // TODO(crbug.com/685570): Fix the tap instead of adding a delay.
- GREYCondition* myCondition = [GREYCondition
- conditionWithName:@"Delay to ensure the toolbar menu can be opened"
- block:^BOOL {
- return NO;
- }];
- [myCondition waitWithTimeout:0.5];
-
[self openHistoryPanel];
chrome_test_util::VerifyAccessibilityForCurrentScreen();
// Close history.
« no previous file with comments | « no previous file | ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698