Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm

Issue 2660513002: Move delay before tapping tools menu to global location. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/history/history_ui_egtest.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm
diff --git a/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm b/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm
index 7cfc95197435d42c64932bc6a4f0955b727495c9..835a55bb74c6e4b6fe48386ceb449f1063de8fcf 100644
--- a/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm
+++ b/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm
@@ -19,6 +19,14 @@ using testing::kWaitForPageLoadTimeout;
@implementation ChromeEarlGreyUI
+ (void)openToolsMenu {
+ // TODO(crbug.com/685570): Fix the tap instead of adding a delay.
+ GREYCondition* myCondition = [GREYCondition
+ conditionWithName:@"Delay to ensure the toolbar menu can be opened"
+ block:^BOOL {
+ return NO;
+ }];
+ [myCondition waitWithTimeout:0.5];
+
// TODO(crbug.com/639524): Add logic to ensure the app is in the correct
// state, for example DCHECK if no tabs are displayed.
[[[EarlGrey
« no previous file with comments | « ios/chrome/browser/ui/history/history_ui_egtest.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698